Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove now redundant mark as read on click functionality #713

Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Jan 19, 2024

Closes #712

@setchy setchy requested a review from bmulholland as a code owner January 19, 2024 12:33
@setchy setchy requested a review from afonsojramos January 19, 2024 12:33
@setchy setchy marked this pull request as draft January 19, 2024 12:55
@setchy setchy marked this pull request as ready for review January 19, 2024 13:11
@setchy setchy requested a review from adufr January 19, 2024 13:19
@bmulholland bmulholland merged commit daa6b60 into gitify-app:main Jan 19, 2024
@bmulholland
Copy link
Collaborator

That was fast! Thanks :)

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still catching up on everything! Alright, looking good!

@setchy setchy deleted the feature/remove-mark-as-read-on-click branch February 19, 2024 12:49
@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Mark as read on click" Setting, which has no effect now
4 participants