-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update/move "unsubscribe" icon #745
feat: update/move "unsubscribe" icon #745
Conversation
Uh oh, idk what happened with my branch management but I was only expecting 2 commits here, not 10, I might have been doing something wrong -- looks like I probably didn't correctly update my fork's main branch 😬 Anyway, the files changed are looking good to me 🤷 |
Looks much cleaner @adufr - thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's better -- thank you!
@adufr - with this now merged, I've been using this What i noticed with the new UX re: the 3 icons, is the following
![]() i'd like to propose we consider:
Would love to hear your thoughts and experience using it thus far. |
@setchy I haven't used it much since I'm only running it while working on it, otherwise I'm still on 4.6.1.. I agree on moving the "Mark as read" icon to the right, which will allow us to align the icon with the "Mark repository as read" icon (which will need to be a bit smaller) And concerning the button height, I'm proposing to make it |
Thank you both for the attention to detail! Both the testing and the fixes are invaluable for the app to remain polished and usable. Much appreciated. |
Interesting analysis there, thanks for the keen eyes 👀 |
Context
As discussed in #706, because of the new "Mark as done" button, the "unsubscribe" button was weirdly positioned, so this PR fixes it by moving icons
I also updated the "unsubscribe" icon to match Github's one (bell-slash)
Before:

After:

Discussion
I changed the order of the icons to something that felt more natural to me / something that looks more like Github's notifications interface (even though they don't provide a "mark notification as read" button).
I guess this is kind of subjective so if you see reasons to not change it, please let me know 😛