Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown parenthesis escape #4085

Closed
wants to merge 1 commit into from
Closed

Conversation

dnicolson
Copy link
Contributor

@dnicolson dnicolson commented Feb 21, 2025

Description

This partially addresses #3246 by not escaping closing parentheses in Markdown commit messages.

Before After

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio
Copy link
Member

eamodio commented Apr 8, 2025

Thanks for the contribution, but I've gone a different direction. Closing in favor of 94d91e7

@eamodio eamodio closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants