Send telemetry on unusual token refreshing #4315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeibbb
added a commit
that referenced
this pull request
May 20, 2025
sergeibbb
added a commit
that referenced
this pull request
May 20, 2025
…ons. We skip refreshing a non-cloud sessions, because we expect it to be a PAT. But now it's rather unexpected situation, so we send an event to be aware about it. (#4315)
sergeibbb
added a commit
that referenced
this pull request
May 20, 2025
…t once Makes sure that we don't send them too frequently: once per session, that's because we basically want to know if there are such cases at all and how many, rather than knowing exact numbes. (#4315)
sergeibbb
force-pushed
the
send-telemetry-on-unusual-token-refreshing
branch
from
774defa to
733710e
Compare
eamodio
approved these changes
May 21, 2025
sergeibbb
added a commit
that referenced
this pull request
May 22, 2025
1. Sends a telemetry event for missing expirity dates. 2. Sends a telemetry events when we skip refreshing of a non-cloud sessions. We skip refreshing a non-cloud sessions, because we expect it to be a PAT. But now it's rather unexpected situation, so we send an event to be aware about it. (#4315)
sergeibbb
added a commit
that referenced
this pull request
May 22, 2025
…t once Makes sure that we don't send them too frequently: once per session, that's because we basically want to know if there are such cases at all and how many, rather than knowing exact numbes. (#4315)
sergeibbb
force-pushed
the
send-telemetry-on-unusual-token-refreshing
branch
from
733710e to
956fe9e
Compare
1. Sends a telemetry event for missing expirity dates. 2. Sends a telemetry events when we skip refreshing of a non-cloud sessions. We skip refreshing a non-cloud sessions, because we expect it to be a PAT. But now it's rather unexpected situation, so we send an event to be aware about it. (#4315)
…t once Makes sure that we don't send them too frequently: once per session, that's because we basically want to know if there are such cases at all and how many, rather than knowing exact numbes. (#4315)
sergeibbb
force-pushed
the
send-telemetry-on-unusual-token-refreshing
branch
from
956fe9e to
b5b9a4b
Compare
sergeibbb
added a commit
that referenced
this pull request
May 22, 2025
1. Sends a telemetry event for missing expirity dates. 2. Sends a telemetry events when we skip refreshing of a non-cloud sessions. We skip refreshing a non-cloud sessions, because we expect it to be a PAT. But now it's rather unexpected situation, so we send an event to be aware about it. (#4315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It sends a telemetry events on on-usual token refreshing:
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses