Skip to content

Opens summary before AI result #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 31, 2025
Merged

Opens summary before AI result #4489

merged 6 commits into from
Jul 31, 2025
+322 −29

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jul 14, 2025 •
edited
Loading

Description

Solves #4328

  • Updates AI provider methods to return the used model before the request is finished. The model is used to form partial document context.
  • Stores partial context in URI that is enough to identify the document and to re-generate the content if it's needed.
  • Stores the usage part of the context in memory that is used for sending feedback.
  • Introduces a blinking hack to the markdown.ts in order to fight VSCode's caching of views (rewriting using the FileSystemProvider didn't help, but it can be reviewed here: 8c365a8

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Removes retired recovery code
c1137a2 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Recovers markdown preview content on tab visibility changes
a669ddc 
Addresses issues where markdown previews may display corrupted or
outdated content
by detecting tab visibility changes and forcing content recovery for
affected documents.
Improves reliability of previews when switching tabs or reopening custom
editors.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Opens the virtual document immediately with metadata header and loadi…
233a7c8 
…ng indicator, load summary when ready.

(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Store AI result context in memory for markdown documents.
a01d144 
Thats because we cannot modify URI of document to review context after
the result is rendered.
(#4328, #4489)
@sergeibbb sergeibbb force-pushed the feature/4328-open-summary-before-result branch from c1137a2 to 20ca261 Compare July 14, 2025 10:58
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Mentions changes of summary documents in CHANGELOG:
ad50837 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Removes retired recovery code
20ca261 
(#4328, #4489)
@sergeibbb sergeibbb force-pushed the 4449-feedback-provider branch from 1f08c2d to f851fe3 Compare July 14, 2025 14:07
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Recovers markdown preview content on tab visibility changes
4e56a83 
Addresses issues where markdown previews may display corrupted or
outdated content
by detecting tab visibility changes and forcing content recovery for
affected documents.
Improves reliability of previews when switching tabs or reopening custom
editors.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Opens the virtual document immediately with metadata header and loadi…
4664de2 
…ng indicator, load summary when ready.

(#4328, #4489)
@sergeibbb sergeibbb force-pushed the feature/4328-open-summary-before-result branch from 20ca261 to 04d5300 Compare July 14, 2025 14:08
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Store AI result context in memory for markdown documents.
efe6429 
Thats because we cannot modify URI of document to review context after
the result is rendered.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Mentions changes of summary documents in CHANGELOG:
00768ab 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 14, 2025
@sergeibbb
Removes retired recovery code
04d5300 
(#4328, #4489)
@d13 d13 linked an issue Jul 22, 2025 that may be closed by this pull request
Support opening an explain summary document before summary content is generated #4328
Closed
9 tasks
d13
d13 reviewed Jul 23, 2025
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

I have one question/consideration on the content design before approving.

@sergeibbb sergeibbb force-pushed the feature/4328-open-summary-before-result branch from 04d5300 to ffef047 Compare July 28, 2025 14:28
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Recovers markdown preview content on tab visibility changes
38f115a 
Addresses issues where markdown previews may display corrupted or
outdated content
by detecting tab visibility changes and forcing content recovery for
affected documents.
Improves reliability of previews when switching tabs or reopening custom
editors.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Opens the virtual document immediately with metadata header and loadi…
bbb323b 
…ng indicator, load summary when ready.

(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Store AI result context in memory for markdown documents.
114126e 
Thats because we cannot modify URI of document to review context after
the result is rendered.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Mentions changes of summary documents in CHANGELOG:
3b0f869 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Removes retired recovery code
3ffca4c 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Uses quote block for the loading content instead of the double divider
ffef047 
(#4328, #4489)
@sergeibbb sergeibbb requested a review from d13 July 28, 2025 14:35
d13
d13 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you still need to rebase, otherwise looks good.

@gitkraken gitkraken deleted a comment from Wbaker7702 Jul 28, 2025
@sergeibbb sergeibbb force-pushed the 4449-feedback-provider branch from f851fe3 to b98dc49 Compare July 28, 2025 16:41
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Store AI result context in memory for markdown documents.
304a868 
Thats because we cannot modify URI of document to review context after
the result is rendered.
(#4328, #4489)
@sergeibbb sergeibbb force-pushed the feature/4328-open-summary-before-result branch from ffef047 to 5aaeed8 Compare July 28, 2025 17:17
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Mentions changes of summary documents in CHANGELOG:
524c468 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Removes retired recovery code
b1b29f4 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Uses quote block for the loading content instead of the double divider
5aaeed8 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Recovers markdown preview content on tab visibility changes
9b3528c 
Addresses issues where markdown previews may display corrupted or
outdated content
by detecting tab visibility changes and forcing content recovery for
affected documents.
Improves reliability of previews when switching tabs or reopening custom
editors.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Opens the virtual document immediately with metadata header and loadi…
9b2954e 
…ng indicator, load summary when ready.

(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Store AI result context in memory for markdown documents.
37e1a97 
Thats because we cannot modify URI of document to review context after
the result is rendered.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Mentions changes of summary documents in CHANGELOG:
9dd5b9c 
(#4328, #4489)
@sergeibbb sergeibbb force-pushed the feature/4328-open-summary-before-result branch from 5aaeed8 to cdf7dfd Compare July 28, 2025 18:08
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Removes retired recovery code
0c470e4 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 28, 2025
@sergeibbb
Uses quote block for the loading content instead of the double divider
cdf7dfd 
(#4328, #4489)
@sergeibbb sergeibbb changed the base branch from 4449-feedback-provider to main July 28, 2025 18:09
@sergeibbb
Copy link
Member Author

sergeibbb commented Jul 28, 2025 •
edited
Loading

@d13

I've changed the base to main branch.

The main difference of what is affected can be seen here:

image

The red areas were implemented differently using a class that was added in another branch.

(the original version was based on #4518, code)

@sergeibbb sergeibbb requested a review from d13 July 28, 2025 18:24
sergeibbb added 6 commits July 31, 2025 13:14
@sergeibbb
Recovers markdown preview content on tab visibility changes
ca53334 
Addresses issues where markdown previews may display corrupted or
outdated content
by detecting tab visibility changes and forcing content recovery for
affected documents.
Improves reliability of previews when switching tabs or reopening custom
editors.
(#4328, #4489)
@sergeibbb
Opens the virtual document immediately with metadata header and loadi…
fe40f2f 
…ng indicator, load summary when ready.

(#4328, #4489)
@sergeibbb
Store AI result context in memory for markdown documents.
f723d09 
Thats because we cannot modify URI of document to review context after
the result is rendered.
(#4328, #4489)
@sergeibbb
Mentions changes of summary documents in CHANGELOG:
4bb09dc 
(#4328, #4489)
@sergeibbb
Removes retired recovery code
dbf0f24 
(#4328, #4489)
@sergeibbb
Uses quote block for the loading content instead of the double divider
888f521 
(#4328, #4489)
@sergeibbb sergeibbb force-pushed the feature/4328-open-summary-before-result branch from cdf7dfd to 888f521 Compare July 31, 2025 11:41
@sergeibbb sergeibbb merged commit 14aaccc into main Jul 31, 2025
3 checks passed
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Recovers markdown preview content on tab visibility changes
aacb59a 
Addresses issues where markdown previews may display corrupted or
outdated content
by detecting tab visibility changes and forcing content recovery for
affected documents.
Improves reliability of previews when switching tabs or reopening custom
editors.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Opens the virtual document immediately with metadata header and loadi…
fb3a2ab 
…ng indicator, load summary when ready.

(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Store AI result context in memory for markdown documents.
567c44d 
Thats because we cannot modify URI of document to review context after
the result is rendered.
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Mentions changes of summary documents in CHANGELOG:
df6d442 
(#4328, #4489)
sergeibbb added a commit that referenced this pull request Jul 31, 2025
@sergeibbb
Removes retired recovery code
470b2d2 
(#4328, #4489)
@sergeibbb sergeibbb deleted the feature/4328-open-summary-before-result branch July 31, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d13 d13 d13 approved these changes

@axosoft-ramint axosoft-ramint Awaiting requested review from axosoft-ramint

@eamodio eamodio Awaiting requested review from eamodio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support opening an explain summary document before summary content is generated
2 participants
@sergeibbb @d13