Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports view first opening is very slow than previous Remote Explorer #11426

Open
Tracked by #11154
mustard-mh opened this issue Jul 18, 2022 · 5 comments
Open
Tracked by #11154

Ports view first opening is very slow than previous Remote Explorer #11426

mustard-mh opened this issue Jul 18, 2022 · 5 comments

Comments

@mustard-mh
Copy link
Contributor

mustard-mh commented Jul 18, 2022

New experimental Ports view improvement. More details see #11154.

Proposal

  • IDE proxy with cache
@mustard-mh mustard-mh mentioned this issue Jul 18, 2022
10 tasks
@mustard-mh mustard-mh changed the title First opening is very slow than previous Remote Explorer Ports view first opening is very slow than previous Remote Explorer Jul 18, 2022
@mustard-mh mustard-mh self-assigned this Jul 18, 2022
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Jul 18, 2022

As we can see in Dev Network, most Waterfalls are spent on VSCode inner process, which we can't speed up or cache it
image

This is due to we are using VSCode's WebviewViewProvider. If we can use Webview to replace it, then we can cache it.

But according to VSCode doc https://code.visualstudio.com/api/references/contribution-points#contributes.views. We need WebviewViewProvider or TreeView once we want to locate it at Panel

(TreeView it's a built-in component don't need those Waterfalls)

cc @akosyakov @jeanp413

@mustard-mh mustard-mh moved this to In Progress in 🚀 IDE Team Jul 18, 2022
@mustard-mh mustard-mh moved this from In Progress to Scheduled in 🚀 IDE Team Jul 18, 2022
@akosyakov
Copy link
Member

akosyakov commented Jul 18, 2022

From your screenshot, it looks like caching will save more than 1s is not it? On my connection it will bring down from 547
ms to 310 ms.

@iQQBot Can we add observability for latency in ws-proxy for blobserve routes? I want to know how much it takes to forward. Maybe we can save some time by caching? It is not much data and should not change often. cc @csweichel

@akosyakov
Copy link
Member

I've unscheduled it for now, since it is tricky.

@stale
Copy link

stale bot commented Oct 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 19, 2022
@mustard-mh mustard-mh added the meta: never-stale This issue can never become stale label Oct 19, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 19, 2022
@shaal
Copy link
Contributor

shaal commented Nov 11, 2022

Github's Codespaces interface has a similar Ports panel.
Clicking on "Ports" panel in Codespaces opens right away with no delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants