Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: unify ports view between web and desktop #7408

Closed
jeanp413 opened this issue Dec 31, 2021 · 9 comments
Closed

Epic: unify ports view between web and desktop #7408

jeanp413 opened this issue Dec 31, 2021 · 9 comments

Comments

@jeanp413
Copy link
Member

jeanp413 commented Dec 31, 2021

Build a prototype of Ports view using webview in VS Code Browser which resembles Ports view from Remote SSH but provides our features.
As a result list difference between features.

@jeanp413 jeanp413 added team: IDE type: improvement Improves an existing feature or existing code labels Dec 31, 2021
@akosyakov
Copy link
Member

We should be careful here. There are features where we should align, and there are important integration points like ports. VS Code ports view is very limited to want we have now and switching to it will block us innovate in this point. I think it makes sense for VS Code desktop since we rely there on Remote SSH for port forwarding. But in case of web it does not make sense. We should rather study our users and improve ports view for them, i.e. how to connect several workspaces in one network with services on localhost, how to represent it in ports view, how to resolve conflicts there and so on. Switching to another view and removing features will rather break experience.

@jeanp413
Copy link
Member Author

jeanp413 commented Jan 3, 2022

Could you point out what features would be missing if we use the tunnel view?

@akosyakov
Copy link
Member

Could you point out what features would be missing if we use the tunnel view?

It would be good if you take time to study it. The point is that we give up quite a lot of control by switching to upsteam server and mostly it is fine. But for bits which are important for our integrations like ports and tasks we should not do it. It would be good do otherwise and collect list of things which are missing and implement them in the supervisor.

@loujaybee
Copy link
Member

loujaybee commented Feb 21, 2022

Will remove this one from the inbox for now, but, it's something we should consider as part of:

@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 25, 2022
@jeanp413 jeanp413 added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels May 26, 2022
@akosyakov akosyakov changed the title Migrate ports view to the new tunnel view unify ports view between web and desktop May 27, 2022
@filiptronicek
Copy link
Member

For some more context:
this is the ports view Gitpod contributes on the Browser version of VS Code:
image

this is the ports view that is bundled into VS Code:
image

@loujaybee
Copy link
Member

loujaybee commented May 31, 2022

As discussed with @jeanp413 and @mustard-mh is that we'll start by:

  1. Unifying the existing browser view to be the same as the desktop view (focusing mainly on the ports view), the justification being that this is a simple starting point.

  2. We'll tackle issues around SSH connections, and achieving parity with Remote - SSH before turning on the functionality also in VS Code Desktop, and remove the dependency on Remote SSH, to gain more freedom over the experience.

Let's scope this issue to part 1, and leave part 2 for another issue 🙏

@loujaybee loujaybee moved this to Scheduled in 🚀 IDE Team May 31, 2022
@mustard-mh mustard-mh moved this from Scheduled to In Progress in 🚀 IDE Team Jun 3, 2022
@mustard-mh mustard-mh moved this from In Progress to In Review in 🚀 IDE Team Jun 14, 2022
@loujaybee loujaybee changed the title unify ports view between web and desktop Epic: unify ports view between web and desktop Jun 28, 2022
@mustard-mh
Copy link
Contributor

@loujaybee to look into what can we do further with this Epic

@loujaybee
Copy link
Member

Complete + shipped 🚢 - If you have any issues or ideas, please let us know!

Announcements:

@loujaybee loujaybee moved this to Done in 🚀 IDE Team Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants