Skip to content

Conversation

@Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Aug 16, 2025

This is a follow up of #64

Since I tested #64 at the beginning with npm, setting the enviornment variable NPM_TOKEN was enough, as npm picked that up, but yarn doesn't do that and it needs the setting npmAuthToken in the .yarnrc.yml settings file to be set correctly.

But when you use that in the CI, the release CI and build CI fail, as NPM_TOKEN is not set everywhere, so it has a default empty value in the CI's .

I tested this entirely with a private registry and it works.

This is one possible fix of the release CI, see #72 for the 2. option (which doesn't work)

- setup authentication correctly, use empty string, if not publishing
@Totto16 Totto16 changed the title Fix yarn authnetication in release CI Fix yarn authentication in release CI Aug 16, 2025
@Totto16 Totto16 changed the title Fix yarn authentication in release CI Fix yarn authentication in release CI (option 1) Aug 16, 2025
@Totto16
Copy link
Collaborator Author

Totto16 commented Aug 16, 2025

I did one final test (from this branch) and it works (finally 🎉 ) https://github.com/gjsify/gnome-shell/actions/runs/17010760574/job/48226492645

@Totto16 Totto16 merged commit f8f5d7b into main Aug 16, 2025
3 checks passed
@Totto16 Totto16 deleted the yarn_authentication_fix branch August 16, 2025 16:58
@JumpLink
Copy link
Collaborator

I did one final test (from this branch) and it works (finally 🎉 ) https://github.com/gjsify/gnome-shell/actions/runs/17010760574/job/48226492645

Nice, thank you very much 🎉

@Totto16
Copy link
Collaborator Author

Totto16 commented Aug 16, 2025

I made a small mistake, so the provenance was attributed to this branch and not the main branch 😓
(See https://search.sigstore.dev/?logIndex=402476839)

So I deleted the npm version, but you can't republish it again)
So in needed to bump the version to 48.0.4 😓

The attestation can be viewed e.g. here https://registry.npmjs.org/-/npm/v1/attestations/@girs%[email protected]
or here https://www.npmjs.com/package/@girs/gnome-shell#provenance
or here https://search.sigstore.dev/?logIndex=402672235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants