gir: Promisify class members in typescript generator #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewlsh
force-pushed
the
ewlsh/fix-promisifying
branch
from
0e4f120 to
f24cf0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Fix merge conflict for gir: Promisify class members in typescript generator #177
swsnr
added a commit
to swsnr/gnome-shell-extension-picture-of-the-day
that referenced
this pull request
Sep 7, 2024
swsnr
added a commit
to swsnr/gnome-shell-extension-picture-of-the-day
that referenced
this pull request
Sep 7, 2024
swsnr
added a commit
to swsnr/gnome-shell-extension-picture-of-the-day
that referenced
this pull request
Sep 7, 2024
Promisify overload methods and search in more parents for finish method
Improves handling of async functions by: - Adding isPromisifiable() to properly filter virtual functions - Fixing parameter parent references in promisified methods - Simplifying Promise return type creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at fixing promisifying...
gi.tsexposes a function calledpromisifyFunctionswhich handles creating promisified versions of functions based on their signature. Eventually this should instead use the async annotations GLib is working to support.Needs testing to ensure output is correct