Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update to use dynamic/decode and require stdlib 0.50 #15

Conversation

richard-viney
Copy link
Contributor

This fixes deprecation warnings on stdlib 0.53.

May warrant a major version bump as the signature of colour.decoder() has changed.

@richard-viney
Copy link
Contributor Author

@hayleigh-dot-dev would you be able to review this?

Copy link
Member

@hayleigh-dot-dev hayleigh-dot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor change to make 💕

gleam.toml Outdated
@@ -6,8 +6,8 @@ repository = { type = "github", user = "gleam-community", repo = "colour" }
gleam = ">= 0.33.0"

[dependencies]
gleam_stdlib = "~> 0.34"
gleam_stdlib = ">= 0.50.0 and < 2.0.0"
gleam_json = ">= 1.0.1 and < 3.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constraint would need bumping now because json.parse was only introduced in 2.2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, version has been updated

This fixes deprecation warnings on stdlib 0.53
@hayleigh-dot-dev
Copy link
Member

Wicked, thank you!

@hayleigh-dot-dev
Copy link
Member

CI failed for reasons unrelated to this PR, I'll update things and fix them manually. Looks good to me (:

@hayleigh-dot-dev hayleigh-dot-dev merged commit fac2e4b into gleam-community:main Feb 15, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants