Implement AbortSignal, AbortController, RequestInit #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not fully implement RequestInit, only what seemed useful. Closes: gleam-lang#4 Closes: gleam-lang#10
|
I've updated the node version as the features have been added in v20. |
lpil
reviewed
Aug 31, 2025
There was a problem hiding this comment.
Thank you for this! There's several different things being added in this PR, but we only accept one change per PR. Could you please extract one feature from this branch and make a PR for just that please. 🙏 Then we can straightforwardly review it and decide what the best approach should be.
|
Of course! I will split this into two PRs, one regarding fetch_options, the other regarding AbortController and AbortSignal, as those two are coupled together functionality wise. AbortController and AbortSignal only make sense once the other is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not fully implement RequestInit, only what seemed useful.
Closes: #4
Closes: #10
Deprecates: #5
Please let me know about naming stuff, docs and other issues