Add bit_array.to_string_lossy
#800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Feb 9, 2025
| // target due to not using the `utf8_codepoint` bit array segment type. Once | ||
| // the JavaScript target supports `utf8_codepoint` this function should be | ||
| // removed. | ||
| @target(javascript) |
There was a problem hiding this comment.
It's a shame so much is needed for JavaScript, and this introduces a new @target, which we have been working hard to remove.
How challenging would it be to have utf8_codepoint support in JavaScript? That seems like it would be a better solution.
There was a problem hiding this comment.
Bit array pattern matching in JS would need to be expanded to support dynamic sizes first, then utf_codepoint could be implemented on top of that.
I think it's reasonable to wait for that to happen, or alternatively a @target can be avoided by either using the longer JS-compatible version on both targets (it works fine on Erlang), or by implementing the JS version directly in JS as an external function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #797.
The separate version of the function for the JavaScript target is a little bit of an eyesore, but can be removed at some future date once
utf_codepointpattern matching is supported on that target.