Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to toml package format #13

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

DavidStirling
Copy link
Member

This PR updates omero-user-token to use the pyproject.toml package format.

Key changes:

  • Migrated setup.py to pyproject.toml for package spec
  • Reworked build system to use python -m build instead of the deprecated python setup.py install command
  • Versioning migrated to setuptools-scm in keeping with other tooling
  • Added an alias to the cli so that omero-user-token now works, not just omero_user_token.
  • Rolled dev dependencies into the main project file as the dev group
  • Final wheel construction and upload now happens with the lowest Python version, rather than the newest available

I've largely kept the build system the same, though since we have a shared wheel between all platforms/versions testing the entire python version matrix might be overkill.

@DavidStirling DavidStirling requested a review from sbesson February 3, 2025 15:59
@DavidStirling DavidStirling linked an issue Feb 3, 2025 that may be closed by this pull request
DavidStirling and others added 2 commits February 3, 2025 16:14
@DavidStirling
Copy link
Member Author

Nice catch, thanks @sbesson

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omero@search-test:~$ omero-user-token get
ERROR: Token for localhost is invalid!
omero@search-test:~$ omero-user-token set -u root
Password: 
Successfully set token: e081e909-bca0-4b84-bbbc-38e0c793b255@localhost:4064
omero@search-test:~$ omero-user-token get
e081e909-bca0-4b84-bbbc-38e0c793b255@localhost:4064

Looks good thanks, proposing to go ahead and tag 0.4.0 tomorrow morning to test the release workflow.

Reading the README, 2 thoughts:

@DavidStirling
Copy link
Member Author

Thanks @sbesson, I've updated the readme.

While both are supported, I think we should prefer omero-user-token over the underscored version as this is more consistent with our other tooling. Nonetheless both will work in this version.

@sbesson sbesson merged commit eb7dfdb into glencoesoftware:master Feb 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade packaging and actions workflows
2 participants