Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop url wheels from project metadata #14

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

DavidStirling
Copy link
Member

Looks like pypi doesn't allow packages which point directly to dependency URLs, which is understandable. This solution is less clean but should be permitted by the index.

@DavidStirling DavidStirling requested a review from sbesson February 4, 2025 09:47
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned separately, we might want to look into solutions to facilitate the consumption of our pre-built wheels in a variety of environments across the project. Immediately, this change fixes the validation issue reported in https://github.com/glencoesoftware/omero-user-token/actions/runs/13132342534 during the upload of the 0.4.0 artifact to the PyPI server, namely

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: zeroc-ice@                               
         https://github.com/glencoesoftware/zeroc-ice-py-linux-x86_64/releases/d
         ownload/20240202/zeroc_ice-3.6.5-cp39-cp39-manylinux_2_28_x86_64.whl ; 
         (platform_system == "Linux" and python_version == "3.9") and extra ==  
         "dev". See https://packaging.python.org/specifications/core-metadata   
         for more information.                                                  

@sbesson sbesson merged commit 7be20d5 into glencoesoftware:master Feb 4, 2025
7 checks passed
@sbesson
Copy link
Member

sbesson commented Feb 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants