Fix missing/broken error messages #2787
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuf6429
commented
Jun 19, 2025
| @@ -286,6 +286,8 @@ export function messageError<Kind extends ErrorKinds>( | |||
| valueString = value.message; | |||
| } else if (typeof value !== "string") { | |||
| valueString = JSON.stringify(value); | |||
| } else { | |||
| valueString = value; | |||
There was a problem hiding this comment.
Essentially, none of the cases above actually handled string, with the last else-if cases handling "everything else than strings".
|
@uuf6429 Can you give an example of a reproduction and the resulting error messages before and after ? |
|
@inferrinizzard simply call PS: I'm guessing this stuff is not tested, otherwise the original problem would have been long caught. I also don't know how/where to test it, the project is pretty big and the test code somewhat messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error messages were showing up like so:
This is because of a problem with handling strings in the custom interpolation function.
How Has This Been Tested?
Tested it manually, that after the change the original error showed up correctly.
PS: This is a rather critical bug IMO - it's decreasing the quality/trustworthiness of the project.