Allow build for web #2828
Open
Allow build for web #2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert imports from node:fs to fs to allow the package.json directive
"browser": {
"fs": false
}
to prevent the fs import to be packaged when building for web.
Fixes glideapps#2763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert imports from node:fs to fs to allow the package.json directive
to prevent the fs import to be packaged when building for web.
Related Issue
Fixes #2763
Motivation and Context
Fixes #2763
Previous Behaviour / Output
Builds for web were failing, unable to find node:fs
New Behaviour / Output
Builds working as expected
How Has This Been Tested?
Run a build in a sample react project with webpack
Screenshots (if appropriate):