-
Notifications
You must be signed in to change notification settings - Fork 5
ci: remove unnecessary tests and glific mocks #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rvignesh89
wants to merge
24
commits into
main
Choose a base branch
from
rvignesh/unmock-filesearch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
bfa053f
ci: remove unnecessary tests and remove glific mocks
rvignesh89 1e64cda
remove smart wait
rvignesh89 61a6f3f
setup ngrok
rvignesh89 c4a337c
add debug logs for ngrok setup
rvignesh89 65abaac
fix assistant create test
rvignesh89 a781332
log messages for ngrok tunnels
rvignesh89 8226fde
remove split for now
rvignesh89 5e233e3
rewrite host-header ngrok
rvignesh89 4e5b9e1
log status
rvignesh89 88fa1e8
fix search
rvignesh89 2019fd4
fix async code path
rvignesh89 d9dc9d1
split slow tests
rvignesh89 662722f
cache backend build outputs
rvignesh89 2ce48d0
run slow tests if label is present
rvignesh89 a883d77
use be cache in e2e tests
rvignesh89 58fb91a
Merge branch 'main' into rvignesh/unmock-filesearch
rvignesh89 e8967cc
trigger e2e slow on push
rvignesh89 ea29e5e
use ngrok.tgz
rvignesh89 8076a7b
fix minor trigger syntax
rvignesh89 b37cf25
use wait-for action
rvignesh89 eb403b6
move slow test to separate group
rvignesh89 aeabb0e
upload ngrok logs
rvignesh89 8b27629
fix test
rvignesh89 e202041
add back retries
rvignesh89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,182 @@ | ||
| name: E2E Slow Tests | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, labeled, unlabeled, push] | ||
| branches: [main] | ||
|
|
||
| concurrency: | ||
| group: e2e-tests-slow | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| cypress-slow: | ||
| if: ${{ contains(github.event.pull_request.labels.*.name, 'e2e-slow') }} | ||
| runs-on: ubuntu-latest | ||
|
|
||
| env: | ||
| ELIXIR_VERSION: "1.18.3-otp-27" | ||
| OTP_VERSION: "27.3.3" | ||
|
|
||
| services: | ||
| postgres: | ||
| image: postgres:14 | ||
| env: | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_PASSWORD: postgres | ||
| POSTGRES_DB: glific_dev | ||
| ports: | ||
| - 5432:5432 | ||
| options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5 | ||
|
|
||
| steps: | ||
| - name: Setup cypress-testing | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Use latest Node.js | ||
| uses: actions/setup-node@v6 | ||
|
|
||
| - name: Setup elixir | ||
| uses: erlef/setup-beam@v1 | ||
|
||
| with: | ||
| elixir-version: ${{ env.ELIXIR_VERSION }} | ||
| otp-version: ${{ env.OTP_VERSION }} | ||
|
|
||
| - name: Download ngrok | ||
| run: | | ||
| wget -q -O ngrok.tgz https://bin.ngrok.com/c/bNyj1mQVY4c/ngrok-v3-stable-linux-amd64.tgz | ||
| tar -xzvf ngrok.tgz | ||
| chmod +x ngrok | ||
| sudo mv ngrok /usr/local/bin/ | ||
|
|
||
| - name: Start ngrok tunnel | ||
| run: | | ||
| ngrok config add-authtoken "${{ secrets.NGROK_AUTHTOKEN }}" | ||
| nohup ngrok http 4000 --pooling-enabled --host-header=glific.test:4000 --log=stdout > ngrok.log 2>&1 & | ||
| sleep 5 | ||
| tail ngrok.log | ||
|
|
||
| - name: Set GLIFIC_API_HOST_OVERRIDE env | ||
| run: | | ||
| NGROK_API_URL="http://127.0.0.1:4040/api/tunnels" | ||
| count=0 | ||
| until curl -s "${NGROK_API_URL}" | grep -q '"public_url"' || [ $count -eq 10 ]; do | ||
| echo "ngrok public_url not ready" | ||
| sleep 2 | ||
| count=$((count+1)) | ||
| done | ||
| API_URL=$(curl -s ${NGROK_API_URL} | jq -r '.tunnels[] | select(.proto=="https") | .public_url') | ||
| if [ -z "$API_URL" ]; then | ||
| API_URL=$(curl -s ${NGROK_API_URL} | jq -r '.tunnels[] | select(.proto=="http") | .public_url') | ||
| fi | ||
| echo "ngrok tunnels" | ||
| curl -s http://127.0.0.1:4040/api/tunnels | ||
| echo "api_url=$API_URL" | ||
|
|
||
| echo "GLIFIC_API_HOST_OVERRIDE=${API_URL}" >> $GITHUB_ENV | ||
|
|
||
| - name: Setup backend (clone and configure) | ||
| run: | | ||
| echo '127.0.0.1 glific.test' | sudo tee -a /etc/hosts | ||
| echo '127.0.0.1 postgres' | sudo tee -a /etc/hosts | ||
| echo '127.0.0.1 api.glific.test' | sudo tee -a /etc/hosts | ||
| mkdir project | ||
| cd project | ||
| echo clone glific repo | ||
| git clone --branch rvignesh/seed-dev-kaapi https://github.com/glific/glific.git | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This branch will be changed once glific PR is merged to master |
||
| echo done. go to dir. | ||
| cd glific | ||
| echo done. start dev.secret.exs config | ||
| cd priv | ||
| mkdir cert | ||
| cd cert | ||
| echo "${{ secrets.TEST_CERTIFICATE }}" > glific.test+1.pem | ||
| echo "${{ secrets.TEST_CERTIFICATE_KEY }}" > glific.test+1-key.pem | ||
| cd ../../ | ||
| cd config | ||
| cp dev.secret.exs.txt dev.secret.exs | ||
| cp .env.dev.txt .env.dev | ||
| sed -i 's/:max_rate_limit_request, 60/:max_rate_limit_request, 300/g' config.exs | ||
| echo copy done. start setup | ||
| cd ../ | ||
|
|
||
| - name: Cache Elixir deps and build | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| project/glific/deps | ||
| project/glific/_build | ||
| key: ${{ runner.os }}-mix-${{ env.ELIXIR_VERSION }}-otp-${{ env.OTP_VERSION }}-${{ hashFiles('project/glific/mix.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-mix-${{ env.ELIXIR_VERSION }}-otp-${{ env.OTP_VERSION }}- | ||
|
|
||
| - name: Setup backend (mix) | ||
| env: | ||
| KAAPI_API_KEY: ${{ secrets.KAAPI_API_KEY }} | ||
| run: | | ||
| cd project/glific | ||
| echo install mix dependencies if not Cached | ||
| mix local.rebar --force | ||
| mix local.hex --force | ||
| mix hex.repo add oban https://getoban.pro/repo --fetch-public-key ${{ secrets.OBAN_PUBLIC_KEY }} --auth-key ${{ secrets.OBAN_PRO_KEY }} | ||
| mix deps.get | ||
| echo done. start installing inotify-tools | ||
| sudo apt-get install inotify-tools | ||
| echo start mix setup | ||
| ENABLE_DB_SSL=false KAAPI_API_KEY=${KAAPI_API_KEY} mix setup | ||
| cd ../../ | ||
|
|
||
| - name: Setup frontend | ||
| run: | | ||
| cd project | ||
| echo clone glific repo | ||
| git clone https://github.com/glific/glific-frontend.git | ||
| echo done. go to repo dir. | ||
| cd glific-frontend | ||
| echo copy env file. | ||
| cp .env.example .env | ||
| echo done. | ||
| cat /proc/sys/fs/inotify/max_user_watches | ||
| echo set watchers | ||
| sudo sysctl fs.inotify.max_user_watches=524288 | ||
| sudo sysctl -p | ||
| cat /proc/sys/fs/inotify/max_user_watches | ||
| echo start yarn setup. | ||
| yarn setup | ||
| echo done. | ||
| cd ../ | ||
|
|
||
| - name: run glific-frontend | ||
| run: | | ||
| cd /home/runner/work/cypress-testing/cypress-testing/project/glific-frontend | ||
| yarn dev & | ||
|
|
||
| - name: run glific | ||
| run: | | ||
| cd /home/runner/work/cypress-testing/cypress-testing/project/glific | ||
| ENABLE_DB_SSL=false OPEN_AI_KEY=${{secrets.OPENAI_KEY}} mix phx.server > phoenix-server.log 2>&1 & | ||
|
|
||
| - name: Wait for frontend to be ready | ||
| uses: iFaxity/wait-on-action@v1.2.1 | ||
|
||
| with: | ||
| resource: https-get://glific.test:4001 | ||
| timeout: 180000 | ||
|
|
||
| - name: Cypress run (filesearch slow) | ||
| run: | | ||
| echo Create cypress.config.ts from example | ||
| cp cypress.config.ts.example cypress.config.ts | ||
| yarn install | ||
| yarn run cypress run --spec cypress/e2e/filesearch/Filesearch.spec.ts --record --key ${{ secrets.CYPRESS_DASHBOARD_KEY }} | ||
|
|
||
| - name: Upload Phoenix server logs | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: phoenix-server-log-filesearch-slow | ||
| path: /home/runner/work/cypress-testing/cypress-testing/project/glific/phoenix-server.log | ||
| if-no-files-found: warn | ||
| retention-days: 7 | ||
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| nodejs 22.21.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid activity type
pushforpull_requestevent.The
pushactivity type is not valid for thepull_requestwebhook event and will cause the workflow to fail validation.Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.11)
[error] 8-8: invalid activity type "push" for "pull_request" Webhook event. available types are "assigned", "auto_merge_disabled", "auto_merge_enabled", "closed", "converted_to_draft", "demilestoned", "dequeued", "edited", "enqueued", "labeled", "locked", "milestoned", "opened", "ready_for_review", "reopened", "review_request_removed", "review_requested", "synchronize", "unassigned", "unlabeled", "unlocked"
(events)
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvignesh89, sounds good! Just a reminder that the fix is simply removingpushfrom thepull_request.typesarray:If you also intended to trigger this workflow on direct pushes to
main, that would need a separate top-levelpush:trigger block. Let me know if you need any help with that!🧠 Learnings used