fix: update broken link in move contacts documentation#3868
fix: update broken link in move contacts documentation#3868shrutisachan08 wants to merge 4 commits intoglific:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughUpdated the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
priyanshu6238
left a comment
There was a problem hiding this comment.
Could you please fix the formatting and revert all unnecessary changes?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3868 +/- ##
==========================================
- Coverage 82.11% 82.09% -0.02%
==========================================
Files 311 311
Lines 13126 13126
Branches 3039 3039
==========================================
- Hits 10778 10776 -2
- Misses 1397 1398 +1
- Partials 951 952 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yeah sure but could you please elaborate on formatting. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/config/index.test.ts`:
- Line 24: Replace the relative dynamic import import('./index') used when
assigning const config with the src-root alias form (e.g.,
import('config/index')) so the test follows the repository's import-path
conventions; update the import expression in the test to use the alias instead
of './index' and keep the result assigned to the same variable (const config) so
behavior is unchanged.
- Around line 14-24: Replace the incorrect vi.stubGlobal('import', ...) usage
with vi.stubEnv({...}) to mock environment variables (set
VITE_GLIFIC_BACKEND_URL, VITE_GLIFIC_API_PORT, VITE_API_PREFIX), call
vi.resetModules() before each dynamic import to ensure module-level constants in
src/config/index.ts are recomputed, import the module using the configured alias
(await import('config')) instead of './index', and ensure cleanup by calling
vi.unstubAllEnvs() and vi.unstubAllGlobals() after each test to avoid state
leakage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c51b3f4c-ae0f-42e5-89d0-ae50463d0297
📒 Files selected for processing (1)
src/config/index.test.ts
40bc8b5 to
5259095
Compare
5259095 to
0b2f9ea
Compare
|
@priyanshu6238 , |
.gitattributes
Outdated
There was a problem hiding this comment.
why is this added in this PR?
There was a problem hiding this comment.
I was facing LF/CRLF formatting issues locally which were causing unnecessary diffs , so I added this to standardize line endings.
There was a problem hiding this comment.
Are you using window?
There was a problem hiding this comment.
Yes .
Initially I tried making the push using wsl but that was creating some username or password issue . So I pushed through windows .
There was a problem hiding this comment.
This won't break the logic but if you want I can remove this .
There was a problem hiding this comment.
yeah since its out of scope for this PR, please remove it
There was a problem hiding this comment.
@akanshaaa19 ,
I have removed .gitattributes in the final commit .
Glific
|
||||||||||||||||||||||||||||
| Project |
Glific
|
| Branch Review |
fix/move-contacts-link
|
| Run status |
|
| Run duration | 11m 03s |
| Commit |
|
| Committer | Priyanshu singh |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
2
|
|
|
0
|
|
|
0
|
|
|
52
|
| View all changes introduced in this branch ↗︎ | |

Summary
The PR fixes the broken link in "Move Contacts" documentation to make users are directed to correct and update resource.
Test plan
Checked manually that the link redirects to correct page on browser
Checked the updated documentation file locally to ensure link is correct.
Fix #3740
Summary by CodeRabbit