Skip to content

fix: update broken link in move contacts documentation#3868

Open
shrutisachan08 wants to merge 4 commits intoglific:masterfrom
shrutisachan08:fix/move-contacts-link
Open

fix: update broken link in move contacts documentation#3868
shrutisachan08 wants to merge 4 commits intoglific:masterfrom
shrutisachan08:fix/move-contacts-link

Conversation

@shrutisachan08
Copy link
Copy Markdown

@shrutisachan08 shrutisachan08 commented Apr 2, 2026

Summary

The PR fixes the broken link in "Move Contacts" documentation to make users are directed to correct and update resource.

Test plan

Checked manually that the link redirects to correct page on browser
Checked the updated documentation file locally to ensure link is correct.

Fix #3740

Summary by CodeRabbit

  • Documentation
    • Updated the contact management help link to point to the new Collections section of the docs.
  • Chores
    • Added repository-wide line-ending normalization rules to enforce LF endings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8f4194a-c72a-4a53-b3d2-82288bc8ed85

📥 Commits

Reviewing files that changed from the base of the PR and between 5259095 and 0b2f9ea.

📒 Files selected for processing (2)
  • .gitattributes
  • src/config/index.ts
✅ Files skipped from review due to trivial changes (2)
  • .gitattributes
  • src/config/index.ts

Walkthrough

Updated the CONTACT_MANAGE_HELP_LINK constant in src/config/index.ts to a new Glific Docs URL: https://glific.github.io/docs/docs/Product%20Features/Others/Collections/#2-move-contacts-bulk-update. Added a .gitattributes file enforcing LF line endings (text=auto, with explicit *.ts, *.tsx, *.js set to eol=lf). No other logic, exports, or control flow were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • shijithkjayan
  • akanshaaa19

Poem

🐰 A link hopped from old to new,
A tiny change, a clearer view.
Docs now lead where answers dwell,
One line fixed the broken spell. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes changes beyond the linked issue: a new .gitattributes file for line-ending normalization was added, which is unrelated to fixing the broken documentation link. Remove the .gitattributes file addition or address it separately, as it is outside the scope of fixing the move contacts documentation link in issue #3740.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: updating a broken documentation link for move contacts.
Linked Issues check ✅ Passed The PR updates CONTACT_MANAGE_HELP_LINK to correct the broken documentation link reported in issue #3740, directly addressing the page-not-found error.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 2, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown
Collaborator

@priyanshu6238 priyanshu6238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the formatting and revert all unnecessary changes?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (d021984) to head (0b2f9ea).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
- Coverage   82.11%   82.09%   -0.02%     
==========================================
  Files         311      311              
  Lines       13126    13126              
  Branches     3039     3039              
==========================================
- Hits        10778    10776       -2     
- Misses       1397     1398       +1     
- Partials      951      952       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shrutisachan08
Copy link
Copy Markdown
Author

Could you please fix the formatting and revert all unnecessary changes?

yeah sure but could you please elaborate on formatting.

@priyanshu6238
Copy link
Copy Markdown
Collaborator

Could you please fix the formatting and revert all unnecessary changes?

yeah sure but could you please elaborate on formatting.

Could you please fix the formatting and revert all unnecessary changes?

yeah sure but could you please elaborate on formatting.

Screenshot 2026-04-06 at 4 42 41 PM

can you see all this changes.They seem to be happening due to formatting issues. Kindly revert all of them except for the change on line 59.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/config/index.test.ts`:
- Line 24: Replace the relative dynamic import import('./index') used when
assigning const config with the src-root alias form (e.g.,
import('config/index')) so the test follows the repository's import-path
conventions; update the import expression in the test to use the alias instead
of './index' and keep the result assigned to the same variable (const config) so
behavior is unchanged.
- Around line 14-24: Replace the incorrect vi.stubGlobal('import', ...) usage
with vi.stubEnv({...}) to mock environment variables (set
VITE_GLIFIC_BACKEND_URL, VITE_GLIFIC_API_PORT, VITE_API_PREFIX), call
vi.resetModules() before each dynamic import to ensure module-level constants in
src/config/index.ts are recomputed, import the module using the configured alias
(await import('config')) instead of './index', and ensure cleanup by calling
vi.unstubAllEnvs() and vi.unstubAllGlobals() after each test to avoid state
leakage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c51b3f4c-ae0f-42e5-89d0-ae50463d0297

📥 Commits

Reviewing files that changed from the base of the PR and between 066e5f0 and 40bc8b5.

📒 Files selected for processing (1)
  • src/config/index.test.ts

@shrutisachan08 shrutisachan08 force-pushed the fix/move-contacts-link branch from 40bc8b5 to 5259095 Compare April 6, 2026 12:33
@shrutisachan08 shrutisachan08 force-pushed the fix/move-contacts-link branch from 5259095 to 0b2f9ea Compare April 6, 2026 13:01
@shrutisachan08
Copy link
Copy Markdown
Author

shrutisachan08 commented Apr 6, 2026

@priyanshu6238 ,
I latest update I have made in PR is free of all formatting issues and ready for review.

@github-actions github-actions bot temporarily deployed to pull request April 6, 2026 15:24 Inactive
.gitattributes Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this added in this PR?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was facing LF/CRLF formatting issues locally which were causing unnecessary diffs , so I added this to standardize line endings.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using window?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes .
Initially I tried making the push using wsl but that was creating some username or password issue . So I pushed through windows .

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't break the logic but if you want I can remove this .

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah since its out of scope for this PR, please remove it

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19 ,
I have removed .gitattributes in the final commit .

Copy link
Copy Markdown
Collaborator

@priyanshu6238 priyanshu6238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cypress
Copy link
Copy Markdown

cypress bot commented Apr 7, 2026

Glific    Run #8152

Run Properties:  status check passed Passed #8152  •  git commit 890dc1da45 ℹ️: Merge 0b2f9ea83e5b82b1d1cf71f4140452c1dca4db24 into d021984dabf01003cb715f9707a0...
Project Glific
Branch Review fix/move-contacts-link
Run status status check passed Passed #8152
Run duration 11m 03s
Commit git commit 890dc1da45 ℹ️: Merge 0b2f9ea83e5b82b1d1cf71f4140452c1dca4db24 into d021984dabf01003cb715f9707a0...
Committer Priyanshu singh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 52
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix broken links - 'move contacts' documentation on the platform

3 participants