-
Notifications
You must be signed in to change notification settings - Fork 57
fix: assistant list UX improvements #3881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdshamoon
wants to merge
30
commits into
master
Choose a base branch
from
issue/4963
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
31ecd59
updated based on feature flag
mdshamoon a6f2b0b
fixed test
mdshamoon 40ea75d
fixed test
mdshamoon 2fee22d
fixed test
mdshamoon a203bde
Merge branch 'master' into issue/4948
mdshamoon 6fbcfb7
added assistants
mdshamoon 0f90527
Merge remote-tracking branch 'origin/issue/4948' into issue/4948
mdshamoon 07efd4e
added better tests
mdshamoon 401f549
fix: assistant list UX improvements
mdshamoon 0fe7e62
added better tests
mdshamoon 21a082d
added better tests
mdshamoon 133966f
Merge remote-tracking branch 'origin/issue/4948' into issue/4963
mdshamoon 99eb43f
Merge branch 'master' into issue/4963
mdshamoon e2bb6f4
fixe dtrst
mdshamoon bbca7c0
Merge remote-tracking branch 'origin/issue/4963' into issue/4963
mdshamoon 15f6984
ficed filer
mdshamoon 1bbb122
Merge branch 'master' into issue/4963
mdshamoon b1a692b
feat: split AssistantOptions into KnowledgeBaseOptions for new assist…
mdshamoon 3e32740
fix: add missing i18n strings for KnowledgeBaseOptions
mdshamoon 2911005
Merge remote-tracking branch 'origin/master' into issue/4963
mdshamoon 46ca002
fix: restore AssistantOptions to legacy design for old assistant UI
mdshamoon baa096d
added fixes in Knowledge base
mdshamoon c461526
merged to master
mdshamoon f32dd06
Merge branch 'master' into issue/4963
priyanshu6238 b19216d
fix test cases
mdshamoon 2050034
Merge remote-tracking branch 'origin/issue/4963' into issue/4963
mdshamoon 0800067
added test for knwoledge base
mdshamoon 3f09c73
Merge branch 'master' into issue/4963
priyanshu6238 4c2ba8f
fix: test case
priyanshu6238 d624aa0
fix: test case
priyanshu6238 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.