Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Updating glimmer-vm to 0.73.0 #324

Merged
merged 1 commit into from
Dec 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/@glimmer/component/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"dependencies": {
"@glimmer/env": "^0.1.7",
"@glimmer/util": "0.65.0",
"@glimmer/util": "0.73.0",
"@glimmer/core": "2.0.0-beta.11",
"broccoli-file-creator": "^2.1.1",
"broccoli-merge-trees": "^3.0.2",
Expand All @@ -43,11 +43,11 @@
"devDependencies": {
"@ember/optional-features": "^0.6.1",
"@glimmer/application-test-helpers": "^1.0.0",
"@glimmer/compiler": "0.65.0",
"@glimmer/interfaces": "0.65.0",
"@glimmer/compiler": "0.73.0",
"@glimmer/interfaces": "0.73.0",
"@glimmer/resolver": "^0.3.0",
"@glimmer/tracking": "2.0.0-beta.11",
"@glimmer/wire-format": "0.65.0",
"@glimmer/wire-format": "0.73.0",
"@types/ember": "~3.0.29",
"@types/ember-qunit": "~3.4.3",
"@types/ember-test-helpers": "~1.0.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/@glimmer/component/src/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import _GlimmerComponent from '../addon/-private/component';
import { DEBUG } from '@glimmer/env';

export default class GlimmerComponent<Args extends {} = {}> extends _GlimmerComponent<Args> {
constructor(owner: unknown, args: Args) {
constructor(owner: object, args: Args) {
super(owner, args);

if (DEBUG && !(owner !== null && typeof owner === 'object')) {
Expand Down
4 changes: 2 additions & 2 deletions packages/@glimmer/component/test/interactive/args-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';

import { setComponentTemplate, createTemplate } from '@glimmer/core';
import { module, test, render, settled } from '@glimmer/core/test/utils';
import { test, render, settled } from '@glimmer/core/test/utils';

module('[@glimmer/component] Component Arguments', () => {
QUnit.module('[@glimmer/component] Component Arguments', () => {
test('Getters that depend on `args` re-render correctly', async function (assert) {
assert.expect(2);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';

import { module, test, render, settled } from '@glimmer/core/test/utils';
import { test, render, settled } from '@glimmer/core/test/utils';
import { setComponentTemplate, createTemplate } from '@glimmer/core';

module('[@glimmer/component] Lifecycle Hooks', () => {
QUnit.module('[@glimmer/component] Lifecycle Hooks', () => {
test('Lifecycle hook ordering', async function (assert) {
assert.expect(2);

Expand Down
28 changes: 11 additions & 17 deletions packages/@glimmer/core/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export {
RenderComponentOptions,
didRender,
getTemplateIterator,
ComponentDefinition,
} from './src/render-component';

export { BaseEnvDelegate } from './src/environment/delegates';
Expand All @@ -12,29 +13,22 @@ export type {
ModifierCapabilities,
ComponentManager,
ComponentCapabilities,
HelperManager,
} from '@glimmer/interfaces';

export { setComponentManager, setModifierManager } from '@glimmer/runtime';
export { setHelperManager } from './src/managers';
export { templateOnlyComponent } from '@glimmer/runtime';

export { TemplateArgs } from './src/interfaces';

export { ModifierDefinition, capabilities as modifierCapabilities } from './src/managers/modifier';

export {
HelperManager,
HelperDefinition,
capabilities as helperCapabilities,
Capabilities as HelperCapabilities,
} from './src/managers/helper';

export {
ComponentDefinition,
capabilities as componentCapabilities,
} from './src/managers/component/custom';
setComponentManager,
setModifierManager,
modifierCapabilities,
setHelperManager,
componentCapabilities,
helperCapabilities,
} from '@glimmer/manager';

export { templateOnlyComponent } from './src/managers/component/template-only';
export { getOwner, setOwner } from '@glimmer/owner';

export { createTemplate, setComponentTemplate } from './src/template';

export { getOwner, setOwner } from './src/owner';
16 changes: 9 additions & 7 deletions packages/@glimmer/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,18 @@
},
"dependencies": {
"@glimmer/env": "^0.1.7",
"@glimmer/global-context": "0.65.0",
"@glimmer/interfaces": "0.65.0",
"@glimmer/opcode-compiler": "0.65.0",
"@glimmer/program": "0.65.0",
"@glimmer/runtime": "0.65.0",
"@glimmer/validator": "0.65.0",
"@glimmer/global-context": "0.73.0",
"@glimmer/interfaces": "0.73.0",
"@glimmer/manager": "0.73.0",
"@glimmer/opcode-compiler": "0.73.0",
"@glimmer/owner": "0.73.0",
"@glimmer/program": "0.73.0",
"@glimmer/runtime": "0.73.0",
"@glimmer/validator": "0.73.0",
"@simple-dom/interface": "^1.4.0"
},
"devDependencies": {
"@glimmer/compiler": "0.65.0",
"@glimmer/compiler": "0.73.0",
"@glimmer/component": "2.0.0-beta.11",
"@glimmer/tracking": "2.0.0-beta.11"
},
Expand Down
10 changes: 10 additions & 0 deletions packages/@glimmer/core/src/environment/delegates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ setGlobalContext({
return obj[key];
},

setPath(obj: Record<string, unknown>, key: string, newValue: unknown) {
if (DEBUG && key.includes('.')) {
throw new Error(
'You attempted to set a path with a `.` in it, but Glimmer.js does not support paths with dots.'
);
}

obj[key] = newValue;
},

scheduleRevalidate,

toBool,
Expand Down
Loading