Add browserify deamdify support #2
Open
+133,132
−6,258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap modules in AMD wrappers for browser-safety; move the files around a bit to conform to standard node/volo package organization. Add 'lzmajs' binary (not yet working) and make test suite mocha-compatible. Add README.
…on code. Stumbled across http://code.google.com/p/js-lzma/ and realized it was identical to the source code for the decompressor I got from upstream.
…les. The test cases are borrowed from the bzip2 source code.
Add tests to verify that our new implementation works properly!
Also added Base class and turned some numbers into symbolic constants. Froze 'package' objects so that (eg) RangeCoder.Encoder can be recognized as a constant.
Reverted some 'improvements' to make this code match the Java upstream more closely as well. Correctness is more important than improvements at this point. (Once the code is working and we have test cases, we might think about 'improving' the code further.)
This helps prevent odd node-only bugs, since the Uint8Array is zero-filled by spec.
Typo: s/typeof('Uint32Array')/typeof(Uint32Array)/
This release consists only of dependency updates.
Actual stable versions
"commander" 2.2.0
"mocha" 1.18.2
The tests are all fine
lzma file decode
✓ should correctly decode sample0
✓ should correctly decode sample1 (117ms)
✓ should correctly decode sample2 (217ms)
✓ should correctly decode sample3
✓ should correctly decode sample4 (937ms)
lzma file encode->decode
✓ encoded sample0 should correctly decode (648ms)
✓ encoded sample1 should correctly decode (2195ms)
✓ encoded sample2 should correctly decode (3769ms)
✓ encoded sample3 should correctly decode (883ms)
✓ encoded sample4 should correctly decode (14460ms)
lzma streaming decode
✓ should correctly decode sample0
✓ should correctly decode sample1 (329ms)
✓ should correctly decode sample2 (679ms)
✓ should correctly decode sample3 (271ms)
✓ should correctly decode sample4 (3200ms)
range coder
✓ encodeDirectBits->decodeDirectBits should be the identity
✓ encode->decodeBit (single context)
✓ encode->decodeBit (1-bit context)
✓ encode->decodeBit (2-bit context)
✓ encode->decodeBit (3-bit context)
✓ encode->decodeBit (4-bit context)
✓ encode->decodeBit (5-bit context)
✓ encode->decodeBit (6-bit context)
✓ encode->decodeBit (7-bit context)
✓ encode->decodeBit (8-bit context)
✓ encode->decodeBit (9-bit context)
✓ encode->decodeBit (10-bit context)
✓ encode->decodeBit (11-bit context)
✓ encode->decodeBit (12-bit context)
✓ encode->decodeBit (13-bit context)
✓ encode->decodeBit (14-bit context)
✓ encode->decodeBit (15-bit context)
✓ encode->decodeBit (16-bit context)
✓ encode->decodeBit (bit-position-based context)
range encoder
✓ should pass a simple test
small sequence
✓ should pass bit tree
✓ should pass bin tree (216ms)
large sequence
✓ should pass bit tree (71ms)
✓ should pass bin tree (195ms)
encode
✓ should pass its tests
40 passing (28s)
Update package.json to latest stable dependencies
The example code did not work, etc. Check out the diffs.
README.md was out of date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this package is written using AMD, which is not well supported by browserify, deamdify has to be used such that this package can be built and executed on browsers. The pull request add additional key to the package.json to signal browserfiy to deamdify the package by default.