You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FYI: the upgrade to React 16 is ready to go once this is merged: paularmstrong@1ef481e. Once that's done, we could go forward with updating to use more ES6, new eslint/prettier/whatever.
Solution: Mostly copies the changes from #76 for rollup. Upgrades babel & mocha.
For that reason, I've cherry-picked the original changes from that branch and applied yours on top of it in an attempt to be fair to both of you @paularmstrong and @diligiant.
FYI: the upgrade to React 16 is ready to go once this is merged: paularmstrong/react-globalize@1ef481e. Once that's done, we could go forward with updating to use more ES6, new eslint/prettier/whatever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
As discovered in #78, the build system needs to be updated in order to unlock updating to React v16.x.
Solution: Mostly copies the changes from #76 for rollup. Upgrades babel & mocha.
Using rollup for react-globalize cuts 2.02KB (gzipped) off the production vendor.js file in Twitter Lite 👍
This will create all of the same formats for builds as #76: cjs, umd, and esm.