-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚🎨👌 Change docs theme from RTD to pydata #324
Conversation
Reviewer's Guide by SourceryThis pull request migrates the documentation theme from No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
@jsnel Have a look at the new pretty docs 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 58.04% 58.04%
=======================================
Files 31 31
Lines 1616 1616
Branches 213 213
=======================================
Hits 938 938
Misses 660 660
Partials 18 18 ☔ View full report in Codecov by Sentry. |
I use a link to a the raw static image svg rather than generation a badge ourt own since it plays nicer accross where you look at the readme and pre-commit will fail below 100% anyway.
Extension error (pydata_sphinx_theme.pygments): Handler <function overwrite_pygments_css at 0x7f93feb0e4d0> for event 'build-finished' threw an exception (exception: [Errno 2] No such file or directory: '/home/runner/work/pyglotaran-extras/pyglotaran-extras/docs/_build/linkcheck/_static/pygments.css') make: *** [Makefile:25: linkcheck] Error 2 make: Leaving directory '/home/runner/work/pyglotaran-extras/pyglotaran-extras/docs'
f5b35f9
to
ae2cf05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see our documentation is now safe to read for us cave dwellers. 👌🌚
It is 2025 and I'm tired of getting flash banged by our docs 😅
While the RTD theme served us for a long time, they do not offer a dark theme version.
Whereas the
pydata
theme offers both light and dark themes as well as a more modern look in general.While working on this I found a bug when running the link checker so I added a workaround here and opened a PR upstream to fix it.
Change summary
Checklist
Summary by Sourcery
Update documentation theme to PyData Sphinx Theme and add an Interrogate badge.
Enhancements:
Documentation:
Tests: