Staging fix relations #1455
Merged
Staging fix relations #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernweissenborn
requested review from
jsnel,
a team and
s-weigand
as code owners
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
The pull request #1455 has too many files changed.
We can only review pull requests with up to 300 changed files, and this pull request has 371.
|
|
This issue can not be reproduced on windows, but comes up on linux See: https://github.com/glotaran/pyglotaran/actions/runs/9245862031/job/25432763696?pr=1455 glotaran/plugin_system/project_io_registration.py:329: error: "Scheme" has no attribute "source_path" [attr-defined] glotaran/plugin_system/project_io_registration.py:355: error: "Result" has no attribute "source_path" [attr-defined] glotaran/plugin_system/project_io_registration.py:408: error: "Result" has no attribute "source_path" [attr-defined]
|
1 task
jsnel
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Reviewed ok, tested that it fixes issues #1429 reported by my.
Some comments:
- The nix related files are unrelated to the fix
- Some mypy issues in project_io_registration were fixed, unrelated to this fix.
- Some commented code was left around (in project_io_registration.py) unrelated to this fix, to be cleaned up later.
jsnel
pushed a commit
to jsnel/pyglotaran
that referenced
this pull request
Jun 2, 2024
- 🧪 Added test for optimization with clp constraints. - 🩹Fixed not copying when reducing matrices in result calculation. - 🧰🩹 Quickfix mypy issue - 🧰⬆️ Update nix flakes --------- Co-authored-by: s-weigand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1429