new criteria and actions for groups #19986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
commented
Jun 13, 2025
| @@ -5855,7 +5855,7 @@ private function assetBusinessRules($condition) | |||
| } | |||
|
|
|||
| // Set the condition (add or update) | |||
| $output = $ruleasset->processAllRules($input, [], [], [ | |||
There was a problem hiding this comment.
Please note this is probably a big change, but I struggle to estimate properly.
It aligns the behavior with RuleTicket as you can see here
Lines 11250 to 11255 in aad5067
Without passing the input to the &output parameter, 'append' group action behaves like an 'assign', no previous groups were passed.
trasher
reviewed
Jun 20, 2025
(Maybe wait for other feedbacks before working on this) |
cedric-anne
reviewed
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add "group" and "group in charge" in both criteria and actions for Business rules for assets.
It has been asked by our ops team to explore the multi-group feature of asset shipped in 11.0