Fix wrong ldap group deletion #20002
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
approved these changes
Jun 17, 2025
|
Tests are failing |
cedric-anne
requested changes
Jun 17, 2025
trasher
reviewed
Jun 17, 2025
trasher
reviewed
Jun 19, 2025
trasher
reviewed
Jun 19, 2025
Lainow
force-pushed
the
fix-ldap-group-deletion
branch
from
79da226 to
11ade80
Compare
trasher
reviewed
Jun 19, 2025
Lainow
force-pushed
the
fix-ldap-group-deletion
branch
from
11ade80 to
af21f63
Compare
trasher
approved these changes
Jun 23, 2025
Co-authored-by: Johan Cwiklinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fix accidental deletion of dynamic groups added by something other than rules
Screenshots (if appropriate):