Remove lowered opacities for some forms UI #20062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree opacity may not be a correct solution; but we still need an indication this is inactive (if it's not yet, I did not test). |
|
Possible suggestion: remove disabled part completly when the toggle is off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
50% opacity for elements can be an accessibility issue when we expect the elements to still be interactive.
This is very easy to see when using the accessibility options in the Rendering tab of the Chrome dev tools.
Reduced contrast vision deficiencies emulation:
The toggle to enable direct access is completely invisible for me with the vision deficiency emulation.
Also, for the Service Catalog tab for KB items it isn't immediately obvious why the tab gets faded out when the article is in the service catalog; Nothing is disabled.
If there are other suggestions for conveying some meanings these locations, I am open to making those changes here.