Fix oauthsso profile habilitation by rule using dynamic group #21476
+117
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rom1-B
reviewed
Oct 16, 2025
stonebuzz
reviewed
Oct 20, 2025
Lainow
force-pushed
the
fix-oauthsso-profile-rule-with-group
branch
from
ec4c10a to
929fada
Compare
stonebuzz
suggested changes
Oct 22, 2025
Rom1-B
suggested changes
Oct 23, 2025
tests/functional/UserTest.php
Outdated
Comment on lines
2422
to
2427
| $group = new \Group(); | ||
| $group_id = $group->add([ | ||
| 'name' => 'SSO Test Group', | ||
| 'comment' => 'Group for SSO testing', | ||
| ]); | ||
| $this->assertGreaterThan(0, $group_id); |
There was a problem hiding this comment.
Please use $this->createItem(...
Rom1-B
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Correction of the addition of permissions to a user during an OauthSSO connection when these are added by rules. For example, the criterion for adding a profile is a group from SCIM, which is therefore added dynamically to the user. During the OauthSSO connection, the permissions are removed.
Screenshots (if appropriate):