Merged
Conversation
8ebc6f9 to
0aa9362
Compare
Read embedded pdbs Copy debug information for scopes and imports Taken from Alexx999#3 Make the output assembly MVID deterministic Fix test locking dlls Add .ToArray() to flush the Linq expression so that it is not evaluated more than once. Better error if the pdb doesn't exist Use cecil from https://github.com/KirillOsenkov/cecil/tree/ilrepack
0aa9362 to
15d48ef
Compare
jpobst
added a commit
to dotnet/android
that referenced
this pull request
Mar 28, 2024
… debug files. (#8839) `ILRepack` has a new (Microsoft) maintainer who is working on modernizing it. This includes updating to a newer version of `Mono.Cecil` which supports `portable` and `embedded` debug symbols: gluck/il-repack#333 Updating to the latest version should fix our issue about being unable to debug `Xamarin.Android.Build.Tasks` or get full stack traces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cecil from https://github.com/KirillOsenkov/cecil/tree/ilrepack
Read embedded pdbs
Copy debug information for scopes and imports
Taken from Alexx999#3
Make the output assembly MVID deterministic
Fix test locking dlls
Add .ToArray() to flush the Linq expression so that it is not evaluated more than once.
Better error if the pdb doesn't exist