Skip to content

Commit

Permalink
Added CI fixes due to Dart 3.
Browse files Browse the repository at this point in the history
  • Loading branch information
diegotori committed May 11, 2023
1 parent 17a8eb4 commit 9644919
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
check-format:
name: Check format using flutter format.
name: Check format using dart format.
runs-on: ubuntu-latest

steps:
Expand All @@ -22,7 +22,7 @@ jobs:
- name: Flutter Action
uses: subosito/flutter-action@v2
- name: Check format
run: flutter format . --set-exit-if-changed
run: dart format . --set-exit-if-changed

lint:
name: Lint
Expand Down
4 changes: 2 additions & 2 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
include: package:flutter_lints/flutter.yaml

analyzer:
strong-mode:
implicit-dynamic: false
language:
strict-raw-types: true
exclude:
- lib/generated_plugin_registrant.dart
errors:
Expand Down
4 changes: 2 additions & 2 deletions example/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
include: package:flutter_lints/flutter.yaml

analyzer:
strong-mode:
implicit-dynamic: false
language:
strict-raw-types: true
exclude:
- lib/generated_plugin_registrant.dart

Expand Down
2 changes: 2 additions & 0 deletions example/lib/app/app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import 'package:flutter/material.dart';
// ignore: depend_on_referenced_packages
import 'package:video_player/video_player.dart';

// TODO: Remove after upgrading Flutter to 3.10
// ignore_for_file: prefer_const_constructors
class ChewieDemo extends StatefulWidget {
const ChewieDemo({
Key? key,
Expand Down
2 changes: 1 addition & 1 deletion lib/src/chewie_player.dart
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ class ChewieController extends ChangeNotifier {

bool get isPlaying => videoPlayerController.value.isPlaying;

Future _initialize() async {
Future<dynamic> _initialize() async {
await videoPlayerController.setLooping(looping);

if ((autoInitialize || autoPlay) &&
Expand Down

0 comments on commit 9644919

Please sign in to comment.