-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for React Native 0.77 #2728
Conversation
Any ideas when this will be merged and released? I am facing the same issue after updating to RN 0.77 |
Do we have any update on this, eta on release? |
me too ... same issue here .. |
Any update on this? |
We will test it and then see how to proceed from this, we might need to change some other libraries and also check the support from |
Facing the same issue should be merged soon. |
This will take some time even though the proposed changes are correct.
|
Lot's of components are not working due to this such error: Dialog, Modal, Alert Dialog, Toast, BottomSheet, ActionSheet and Select. Oh please merge this....! |
Yeah. Same here |
Can we somehow make it conditional? Like if removeListener is available then use that otherwise use the new way? |
@kamlesh-tp I think it is unnescessary to make it conditional. |
This is being worked in PR 2744 |
React Native 0.77 has remove
BackHandler.removeEventListener
in #44d6194, and it causes app to crash when upgrading to version 0.77.I updated the code with
useRef
to store subscription returned byBackHandler.addEventListener
and replaceBackHandler.removeEventListener
with theremove
method of the subscription.As stated in this old commit #2596b2f. There should be
remove
method in the returned subscription in previous React Native version, so it won't affect old React Native version.