Skip to content

chore: update all dependencies #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

ThijsBroersen
Copy link
Contributor

@ThijsBroersen ThijsBroersen commented Jan 9, 2025

Was playing a bit with the lib to test some things. Updated all dependencies, works on-my-machine..

@gmkumar2005
Copy link
Owner

@ThijsBroersen Pease help fix the build issue. "/home/runner/work/_temp/7230c03e-9d24-4e7c-8c65-9a18022a0b3b.sh: line 1: sbt: command not found"

@ThijsBroersen
Copy link
Contributor Author

@ThijsBroersen Pease help fix the build issue. "/home/runner/work/_temp/7230c03e-9d24-4e7c-8c65-9a18022a0b3b.sh: line 1: sbt: command not found"

Bumped all workflow actions and added sbt/setup-sbt because sbt is missing in ubuntu-latest (which is now 24.04)

@ThijsBroersen
Copy link
Contributor Author

ThijsBroersen commented Jan 13, 2025

@gmkumar2005 please approve the workflow so we can finalize this PR: https://github.com/gmkumar2005/scala-js-env-playwright/actions/runs/12745512776

@ThijsBroersen
Copy link
Contributor Author

I think the failure has to do with the committed metals.sbt. Let me try and remove it.

@ThijsBroersen
Copy link
Contributor Author

hmm, where does the compiler option come from? warnings found and -Werror specified
Locally it does not fail on warnings, on CI it does.

@ThijsBroersen
Copy link
Contributor Author

@gmkumar2005 disabled warnings in javacOptions and removed Werror explicitly

@ThijsBroersen
Copy link
Contributor Author

ThijsBroersen commented Jan 13, 2025

@gmkumar2005
Copy link
Owner

How to get the new token ?

@ThijsBroersen
Copy link
Contributor Author

Looks like it is not allowed because the run is triggered on a PR from my forked repo: https://github.com/scalacenter/sbt-dependency-submission?tab=readme-ov-file#unexpected-status-403

@ThijsBroersen
Copy link
Contributor Author

And docs say you should only use this on the default branch. So this step should be skipped for PR's. Let me adjust it.

@gmkumar2005
Copy link
Owner

Do we need the dependency snapshot? If not plz remove it.

@ThijsBroersen
Copy link
Contributor Author

what snapshot dependency?

@ThijsBroersen
Copy link
Contributor Author

All green!

@gmkumar2005 gmkumar2005 merged commit f9fd433 into gmkumar2005:main Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants