Skip to content

feat: allow for custom launchOptions on PWEnv #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat: allow for custom launchOptions on PWEnv #13

merged 1 commit into from
Jan 14, 2025

Conversation

ThijsBroersen
Copy link
Contributor

@ThijsBroersen ThijsBroersen commented Jan 13, 2025 •
edited
Loading

PWEnv now has two new parameters:

  • launchOptions for overriding all options
  • additionalLaunchOptions for adding options

@ThijsBroersen ThijsBroersen mentioned this pull request Jan 13, 2025
Open
@ThijsBroersen
Copy link
Contributor Author

@gmkumar2005 I refactored PWEnv.Config a bit, it looked like a weird java-like structure 🫤 . I started adding the launchOptions there but then I decided to add them directly to PWEnv.
Do you want to keep the refactor or shall I revert it to the 'do-it-all-manual' version 🙃 ?

@ThijsBroersen
Copy link
Contributor Author

I also attempted to fix the Webkit tests (running on Ubuntu here) but was not able to ....
Getting errors like run completed and did not call onOutputStream which do not really help debugging it.

@gmkumar2005 gmkumar2005 merged commit 4f6b001 into gmkumar2005:main Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThijsBroersen @gmkumar2005