Rpc fallbacks #1583
Open
Rpc fallbacks #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
divhead
commented
Feb 26, 2025
•
divhead
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1209415042251921
✅ Deploy Preview for vigilant-albattani-df38ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying gmx-interface with
|
| Latest commit: |
0f0ab5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8530015.gmx-interface.pages.dev |
| Branch Preview URL: | https://rpc-fallbacks.gmx-interface.pages.dev |
gmxer
requested changes
Feb 27, 2025
src/config/chains.ts
Outdated
| const filteredPrivateUrls = PRIVATE_PROVIDERS[chainId].filter((url) => !blackListedUrls.includes(url)); | ||
|
|
||
| const [urls1, urls2] = | ||
| priority === "public" ? [filteredPublicUrls, filteredPrivateUrls] : [filteredPrivateUrls, filteredPublicUrls]; |
There was a problem hiding this comment.
I think whole function could be just
priority === 'public' ? getPublic() ?? getPrivate() : getPrivate() ?? getPublic();
src/lib/rpc/bestRpcTracker.ts
Outdated
| ? filteredProviders | ||
| : filteredProviders.filter(({ isPublic }) => isPublic); | ||
|
|
||
| probeResults = await probeProviders(chainId, providersList); |
There was a problem hiding this comment.
in case of empty list shouldn't we whitelist back some of rpcs here?
src/lib/rpc/bestRpcTracker.ts
Outdated
| }); | ||
|
|
||
| // Recalculate best providers with failed RPC blacklisted | ||
| const nextProviderUrls = await getBestRpcProvidersForChain(chainState, [rpcUrl]); |
There was a problem hiding this comment.
am I understanding correctly that there could be only one blacklisted rpc at time?
why don't you store blacklistedRpcs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.