Multichain lp #1810

midas-myth · 2025-08-06T13:02:53Z

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1210975771610337

netlify · 2025-08-06T13:02:59Z

✅ Deploy Preview for vigilant-albattani-df38ec ready!

Name	Link
🔨 Latest commit	`6f6425f`
🔍 Latest deploy log	https://app.netlify.com/projects/vigilant-albattani-df38ec/deploys/68d66379f323bc0008bc5039
😎 Deploy Preview	https://deploy-preview-1810--vigilant-albattani-df38ec.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

cloudflare-workers-and-pages · 2025-08-06T13:04:11Z

Deploying gmx-interface with Cloudflare Pages

Latest commit:	`eec0d14`
Status:	✅ Deploy successful!
Preview URL:	https://cf8e7a23.gmx-interface.pages.dev
Branch Preview URL:	https://multichain-lp.gmx-interface.pages.dev

View logs

…tichain-lp

…ain-lp

… for ExpressEstimationInsufficientGasPaymentTokenBalanceError. Update BridgeOutModal to remove unused label and modify estimateExpressParams to throw error without message for improved clarity.

…introducing initial wrapped token address handling and updating amount calculations for initial long and short tokens. This improves accuracy in fee estimations for market token deposits and ensures proper handling of wrapped tokens.

…e UI interactions. Replace deprecated icons with updated SVGs, and implement a dropdown menu for deposit and withdrawal actions, improving user experience and accessibility in the pools details view.

…improve clarity. Update stargateTransferFees to return native fees and gas limits directly, enhancing consistency across fee estimation calculations for various token transfers.

divhead · 2025-11-27T17:06:25Z

sdk/src/utils/markets.ts

 }

+export function getOppositeCollateralFromConfig(marketConfig: MarketConfig, tokenAddress: string) {
+  return marketConfig.shortTokenAddress === tokenAddress


Should we check for getIsEquivalentTokens?

based on usage, no

divhead · 2025-11-27T17:06:58Z

sdk/src/utils/markets.ts

 }
+
+export function isMarketTokenAddress(chainId: number, marketTokenAddress: string): boolean {
+  return Boolean(MARKETS[chainId]?.[marketTokenAddress]);


let's don't use MARKETS directly and it could be in configs file

divhead · 2025-11-27T17:08:14Z

sdk/src/utils/markets.ts

+}
+
+export function getMarketIndexTokenSymbol(chainId: number, marketTokenAddress: string): string {
+  const indexToken = getMarketIndexToken(chainId, marketTokenAddress);


redundant function, it could be just getIndexToken().symbol

divhead · 2025-11-27T17:09:06Z

sdk/src/utils/markets.ts

+  return indexToken.symbol;
+}
+
+export function getMarketLongTokenAddress(chainId: number, marketTokenAddress: string): string {


getTokenAddressByMarket(chain, market, 'long' | 'short' | 'index')

divhead · 2025-11-27T17:09:48Z

sdk/src/utils/markets.ts

+  return MARKETS[chainId][marketTokenAddress].shortTokenAddress;
+}
+
+export function getMarketLongToken(chainId: number, marketTokenAddress: string): Token {


getToken(getTokenByMarket())

divhead · 2025-11-27T17:16:35Z

sdk/package.json

    "build:esm": "tsc -p tsconfig.esm.json && echo '{\"type\": \"module\"}' > build/esm/src/package.json",
    "build:types": "tsc -p tsconfig.json --emitDeclarationOnly",
-    "build:subsquid": "./node_modules/@graphql-codegen/cli/cjs/bin.js -c subsquid-codegen.ts",
+    "build:subsquid": "./node_modules/@graphql-codegen/cli/cjs/bin.js -c subsquid-codegen.ts && npx prettier --write src/types/subsquid.ts",


divhead · 2025-11-27T17:20:33Z

src/components/BridgeModal/BridgeInModal.tsx

+
+  const sourceChainBalancesForSelector: Partial<Record<AnyChainId | 0, bigint>> =
+    multichainMarketTokenBalances?.balances
+      ? mapValues(


Obect.entries().filter([balanceChainId] => Number(balanceChainId) != chainId).reduce(...)

divhead · 2025-11-27T17:22:10Z

src/components/BridgeModal/BridgeInModal.tsx

+      ? mapValues(
+          pickBy(multichainMarketTokenBalances.balances, (data, chainIdStr) => {
+            const chainIdNum = Number(chainIdStr);
+            return data && chainIdNum !== chainId && chainIdNum !== 0;


balanceChainId
why !== 0?

to filter out gmx acc, replaced with GMX_ACCOUNT_PSEUDO_CHAIN_ID

divhead · 2025-11-27T17:26:00Z

src/components/BridgeModal/BridgeOutModal.tsx

+    return {
+      token: glvOrMarketAddress as Address,
+      amount: bridgeOutAmount,
+      minAmountOut: 0n,


let's move outside component

divhead · 2025-11-27T17:26:35Z

src/components/BridgeModal/BridgeOutModal.tsx

+    return expressTransactionBuilder;
+  }, [account, bridgeOutChain, bridgeOutParams, chainId]);
+
+  const expressTxnParamsAsyncResult = useArbitraryRelayParamsAndPayload({


seems not async

what do you mean ?
the type returned is

const expressTxnParamsAsyncResult: AsyncResult<ExpressTxnParams>

divhead · 2025-11-27T17:29:02Z

src/components/GmSwap/GmSwapBox/GmDepositWithdrawalBox/lpTxn/useDepositTransactions.tsx

+      ]);
+    }
+
+    return getTransferRequests([


let's move outside of the component

divhead · 2025-11-27T17:35:01Z

src/components/GmxAccountModal/GmxAccountModal.tsx

    }
  }, [account, isVisibleOrView, setIsVisibleOrView]);

+  // TODO move this out of the abstract gmx account modal in container


divhead · 2025-11-27T18:42:38Z

src/context/PoolsDetailsContext/selectors/selectMultichainMarketTokenBalances.ts

+          balance: walletBalance,
+          balanceUsd: walletBalanceUsd,
+        },
+        [0]: {


replaced with GMX_ACCOUNT_PSEUDO_CHAIN_ID

divhead · 2025-11-27T18:48:55Z

src/domain/multichain/progress/__tests__/tracker.spec.ts

+    );
+  });
+
+  it.skip("sepolia glv market buy", { timeout: 30_000 }, async () => {


skipped test

unskipped both in that file

…nd efficiency. Remove unused selectors for GLV and market tokens, and streamline logic for updating token inputs based on collateral types. Enhance withdrawal calculations to account for same collateral scenarios, ensuring accurate token amount handling during deposits and withdrawals.

…hain market token balances, improving balance checks for market tokens. Update logic to ensure only tokens with available balances are considered, enhancing accuracy in token option selection.

… state management. Replace dynamic toast ID generation with a constant identifier for better clarity and consistency. Clean up unused state variables and streamline effect dependencies for enhanced performance.

… to enhance multichain support. Update token handling in various components to utilize the new pseudo chain ID, improving balance management and user experience across the application.

…o getTokenSymbolByMarket. Update related components to utilize the new function for improved clarity and maintainability in token symbol handling across the application.

…tichain-lp

…retaining the option for future reference.

… for insufficient token balances. Update localization files to include new error message format for various languages.

divhead · 2025-12-01T05:17:34Z

src/lib/wallets/rainbowKitConfig.ts

-      [botanix.id]: http(),
-      [bsc.id]: http(),
-    },
+    transports: [


don't we have a mapping of supported chains -> viem chains to not edit this place when we support new chain?

midas-myth added 9 commits August 8, 2025 14:40

Multichain add gmx acc gm deposit

9cfa2ee

Implement crosschain deposit functionality

249df5c

Multichain lp

e070a1a

Refactor multichain deposit

337610d

Multichain fix tests

2134728

GmDepositWithdrawalBox remove unused state

b35d637

Refactor multichain deposit

359f9cf

multichain gm eth

7d97554

Refactor GmDepositWithdrawalBox

7927495

midas-myth force-pushed the multichain-lp branch from bc422b7 to 7927495 Compare August 8, 2025 12:43

midas-myth added 9 commits August 14, 2025 16:16

Multichain update contracts addresses

5fe5fec

Merge branch 'release-82' of github.com:gmx-io/gmx-interface into mul…

6fb9b7b

…tichain-lp

Multichain lp mark correct pay source for second token in pair

7ac49de

Multichain lp reset pay source on gm tradebox change

646f99c

Multichain lp rename pay source type

c8ad488

Multichain change pools header

b8f7233

Sync translations

a27dda4

Multichain LP big txn refactor

671626b

Merge branch 'release-82' of github.com:gmx-io/gmx-interface into mul…

11e6322

…tichain-lp

midas-myth self-assigned this Sep 18, 2025

midas-myth changed the base branch from multichain-layout to release-82 September 18, 2025 21:50

midas-myth added 7 commits September 22, 2025 14:20

Multichain LP init all txn

70f24d0

Multichain LP single sell

9e54846

Merge branch 'release-83' of github.com:gmx-io/gmx-interface into mul…

a6d08b2

…tichain-lp

Replace icon components

20c56d8

Merge branch 'master' of github.com:gmx-io/gmx-interface into multich…

641583a

…ain-lp

Multichain lp glv sell to single

f3cbcef

Refactor expressTransactionBuilder condition for clarity

6f6425f

midas-myth added 2 commits November 26, 2025 17:25

Refactor error handling in useArbitraryError to include specific case…

7289ccb

… for ExpressEstimationInsufficientGasPaymentTokenBalanceError. Update BridgeOutModal to remove unused label and modify estimateExpressParams to throw error without message for improved clarity.

midas-myth marked this pull request as ready for review November 26, 2025 17:02

midas-myth added 2 commits November 26, 2025 20:30

Refactor PoolsDetailsHeader to utilize new icon components and enhanc…

895d77f

…e UI interactions. Replace deprecated icons with updated SVGs, and implement a dropdown menu for deposit and withdrawal actions, improving user experience and accessibility in the pools details view.

Refactor fee estimation functions to standardize variable naming and …

440683b

…improve clarity. Update stargateTransferFees to return native fees and gas limits directly, enhancing consistency across fee estimation calculations for various token transfers.

divhead reviewed Nov 27, 2025

View reviewed changes

midas-myth added 3 commits November 28, 2025 00:27

Enhance selectPoolsDetailsTokenOptions selector to incorporate multic…

1427702

…hain market token balances, improving balance checks for market tokens. Update logic to ensure only tokens with available balances are considered, enhancing accuracy in token option selection.

Refactor MultichainTransferProgressView to improve toast handling and…

b765ced

… state management. Replace dynamic toast ID generation with a constant identifier for better clarity and consistency. Clean up unused state variables and streamline effect dependencies for enhanced performance.

midas-myth force-pushed the multichain-lp branch from dc21d1d to 638a0b4 Compare November 28, 2025 00:50

Implement GMX_ACCOUNT_PSEUDO_CHAIN_ID and refactor related components…

13bd2f7

… to enhance multichain support. Update token handling in various components to utilize the new pseudo chain ID, improving balance management and user experience across the application.

midas-myth force-pushed the multichain-lp branch from 638a0b4 to 13bd2f7 Compare November 28, 2025 00:51

midas-myth added 4 commits November 28, 2025 02:15

Refactor market token symbol retrieval by consolidating functions int…

1073dc4

…o getTokenSymbolByMarket. Update related components to utilize the new function for improved clarity and maintainability in token symbol handling across the application.

Merge branch 'release-90' of github.com:gmx-io/gmx-interface into mul…

d49922a

…tichain-lp

Comment out the Base RPC URL in chains.ts to prevent its usage while …

f975e95

…retaining the option for future reference.

Enhance gas payment validation by introducing specific error messages…

eec0d14

… for insufficient token balances. Update localization files to include new error message format for various languages.

divhead reviewed Dec 1, 2025

View reviewed changes

Multichain lp #1810

Are you sure you want to change the base?

Multichain lp #1810

Conversation

midas-myth commented Aug 6, 2025 • edited by xhiroz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vigilant-albattani-df38ec ready!

Uh oh!

cloudflare-workers-and-pages bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying gmx-interface with Cloudflare Pages

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

divhead Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

midas-myth Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

midas-myth commented Aug 6, 2025 •

edited by xhiroz

Loading

netlify bot commented Aug 6, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 6, 2025 •

edited

Loading

divhead Nov 27, 2025 •

edited

Loading

midas-myth Nov 28, 2025 •

edited

Loading