update oracle keeper to use LB API endpoint with fallbacks

sdk/src/configs/__tests__/markets.spec.ts

@@ -13,7 +13,7 @@ type KeeperMarket = {
 };
 
 const getKeeperMarkets = async (chainId: number): Promise<{ markets: KeeperMarket[] }> => {
-  const res = await fetch(`${getOracleKeeperUrl(chainId, 0)}/markets`);
+  const res = await fetch(`${getOracleKeeperUrl(chainId)}/markets`);
   const data = (await res.json()) as {
     markets: KeeperMarket[];
   };

sdk/src/configs/__tests__/tokens.spec.ts

@@ -13,7 +13,7 @@ type KeeperToken = {
 };
 
 const getKeeperTokens = async (chainId: number): Promise<{ tokens: KeeperToken[] }> => {
-  const res = await fetch(`${getOracleKeeperUrl(chainId, 0)}/tokens`);
+  const res = await fetch(`${getOracleKeeperUrl(chainId)}/tokens`);
   const data = (await res.json()) as {
     tokens: KeeperToken[];
   };

sdk/src/configs/oracleKeeper.ts

@@ -1,54 +1,37 @@
-import random from "lodash/random";
-import sample from "lodash/sample";
-
 import { ARBITRUM, AVALANCHE, AVALANCHE_FUJI, BOTANIX, UiContractsChain } from "./chains";
 
-const ORACLE_KEEPER_URLS: Record<UiContractsChain, string[]> = {
-  [ARBITRUM]: ["https://arbitrum-api.gmxinfra.io", "https://arbitrum-api.gmxinfra2.io"],
+const ORACLE_KEEPER_URLS: Record<UiContractsChain, string> = {
+  [ARBITRUM]: "https://arbitrum-api.gmxinfra.io",
 
-  [AVALANCHE]: ["https://avalanche-api.gmxinfra.io", "https://avalanche-api.gmxinfra2.io"],
+  [AVALANCHE]: "https://avalanche-api.gmxinfra.io",
 
-  [AVALANCHE_FUJI]: ["https://synthetics-api-avax-fuji-upovm.ondigitalocean.app"],
+  [AVALANCHE_FUJI]: "https://synthetics-api-avax-fuji-upovm.ondigitalocean.app",
 
-  [BOTANIX]: ["https://botanix-api.gmxinfra.io", "https://botanix-api.gmxinfra2.io"],
+  [BOTANIX]: "https://botanix-api.gmxinfra.io",
 };
 
-export function getOracleKeeperUrl(chainId: number, index: number) {
-  const urls = ORACLE_KEEPER_URLS[chainId];
+const ORACLE_KEEPER_FALLBACK_URLS: Record<UiContractsChain, string[]> = {
+  [ARBITRUM]: ["https://arbitrum-api-fallback.gmxinfra.io", "https://arbitrum-api-fallback.gmxinfra2.io"],
 
-  if (!urls.length) {
-    throw new Error(`No oracle keeper urls for chain ${chainId}`);
-  }
+  [AVALANCHE]: ["https://avalanche-api-fallback.gmxinfra.io", "https://avalanche-api-fallback.gmxinfra2.io"],
 
-  return urls[index] || urls[0];
-}
+  [AVALANCHE_FUJI]: ["https://synthetics-api-avax-fuji-upovm.ondigitalocean.app"],
 
-export function getOracleKeeperNextIndex(chainId: number, currentIndex: number) {
-  const urls = ORACLE_KEEPER_URLS[chainId];
+  [BOTANIX]: ["https://botanix-api-fallback.gmxinfra.io", "https://botanix-api-fallback.gmxinfra2.io"],
+};
 
-  if (!urls.length) {
-    throw new Error(`No oracle keeper urls for chain ${chainId}`);
+export function getOracleKeeperUrl(chainId: number) {
+  if (!ORACLE_KEEPER_URLS[chainId]) {
+    throw new Error(`No oracle keeper url for chain ${chainId}`);
   }
 
-  return urls[currentIndex + 1] ? currentIndex + 1 : 0;
+  return ORACLE_KEEPER_URLS[chainId];
 }
 
-export function getOracleKeeperRandomIndex(chainId: number, bannedIndexes?: number[]): number {
-  const urls = ORACLE_KEEPER_URLS[chainId];
-
-  if (bannedIndexes?.length) {
-    const filteredUrls = urls.filter((url, i) => !bannedIndexes.includes(i));
-
-    if (filteredUrls.length) {
-      const url = sample(filteredUrls);
-
-      if (!url) {
-        throw new Error(`No oracle keeper urls for chain ${chainId}`);
-      }
-
-      return urls.indexOf(url);
-    }
+export function getOracleKeeperFallbackUrls(chainId: number) {
+  if (!ORACLE_KEEPER_FALLBACK_URLS[chainId]) {
+    throw new Error(`No oracle keeper fallback urls for chain ${chainId}`);
   }
 
-  return random(0, urls.length - 1);
+  return ORACLE_KEEPER_FALLBACK_URLS[chainId];
 }

src/config/localStorage.ts

@@ -25,7 +25,6 @@ export const LEVERAGE_ENABLED_KEY = "leverage-enabled";
 export const KEEP_LEVERAGE_FOR_DECREASE_KEY = "Exchange-keep-leverage";
 export const TRADE_LINK_KEY = "trade-link";
 export const SHOW_DEBUG_VALUES_KEY = "show-debug-values";
-export const ORACLE_KEEPER_INSTANCES_CONFIG_KEY = "oracle-keeper-instances-config";
 export const SORTED_MARKETS_KEY = "sorted-markets-key";
 export const TWAP_NUMBER_OF_PARTS_KEY = "twap-number-of-parts";
 export const TWAP_INFO_CARD_CLOSED_KEY = "twap-info-card-closed";

src/context/SettingsContext/SettingsContextProvider.tsx

@@ -1,7 +1,7 @@
 import noop from "lodash/noop";
-import { Dispatch, ReactNode, SetStateAction, createContext, useContext, useEffect, useMemo, useState } from "react";
+import { ReactNode, createContext, useContext, useEffect, useMemo, useState } from "react";
 
-import { ARBITRUM, BOTANIX, EXECUTION_FEE_CONFIG_V2, SUPPORTED_CHAIN_IDS } from "config/chains";
+import { ARBITRUM, BOTANIX, EXECUTION_FEE_CONFIG_V2 } from "config/chains";
 import { isDevelopment } from "config/env";
 import { DEFAULT_ACCEPTABLE_PRICE_IMPACT_BUFFER, DEFAULT_SLIPPAGE_AMOUNT } from "config/factors";
 import {
@@ -10,7 +10,6 @@ import {
   EXTERNAL_SWAPS_ENABLED_KEY,
   IS_AUTO_CANCEL_TPSL_KEY,
   IS_PNL_IN_LEVERAGE_KEY,
-  ORACLE_KEEPER_INSTANCES_CONFIG_KEY,
   SETTINGS_WARNING_DOT_VISIBLE_KEY,
   SHOULD_SHOW_POSITION_LINES_KEY,
   SHOW_DEBUG_VALUES_KEY,
@@ -29,7 +28,6 @@ import { useLocalStorageByChainId, useLocalStorageSerializeKey } from "lib/local
 import { tenderlyLsKeys } from "lib/tenderly";
 import useWallet from "lib/wallets/useWallet";
 import { getDefaultGasPaymentToken } from "sdk/configs/express";
-import { getOracleKeeperRandomIndex } from "sdk/configs/oracleKeeper";
 import { DEFAULT_TWAP_NUMBER_OF_PARTS } from "sdk/configs/twap";
 
 export type SettingsContextType = {
@@ -42,8 +40,6 @@ export type SettingsContextType = {
   setSavedAcceptablePriceImpactBuffer: (val: number) => void;
   executionFeeBufferBps: number | undefined;
   shouldUseExecutionFeeBuffer: boolean;
-  oracleKeeperInstancesConfig: { [chainId: number]: number };
-  setOracleKeeperInstancesConfig: Dispatch<SetStateAction<{ [chainId: number]: number } | undefined>>;
   showPnlAfterFees: boolean;
   setShowPnlAfterFees: (val: boolean) => void;
   isPnlInLeverage: boolean;
@@ -128,17 +124,6 @@ export function SettingsContextProvider({ children }: { children: ReactNode }) {
   );
   const shouldUseExecutionFeeBuffer = Boolean(EXECUTION_FEE_CONFIG_V2[chainId].defaultBufferBps);
 
-  const [oracleKeeperInstancesConfig, setOracleKeeperInstancesConfig] = useLocalStorageSerializeKey(
-    ORACLE_KEEPER_INSTANCES_CONFIG_KEY,
-    SUPPORTED_CHAIN_IDS.reduce(
-      (acc, chainId) => {
-        acc[chainId] = getOracleKeeperRandomIndex(chainId);
-        return acc;
-      },
-      {} as { [chainId: number]: number }
-    )
-  );
-
   const [savedShowPnlAfterFees, setSavedShowPnlAfterFees] = useLocalStorageSerializeKey(
     [chainId, SHOW_PNL_AFTER_FEES_KEY],
     true
@@ -237,8 +222,6 @@ export function SettingsContextProvider({ children }: { children: ReactNode }) {
       executionFeeBufferBps,
       setExecutionFeeBufferBps,
       shouldUseExecutionFeeBuffer,
-      oracleKeeperInstancesConfig: oracleKeeperInstancesConfig!,
-      setOracleKeeperInstancesConfig,
       savedAcceptablePriceImpactBuffer: savedAcceptablePriceImpactBuffer!,
       setSavedAcceptablePriceImpactBuffer,
       showPnlAfterFees: savedShowPnlAfterFees!,
@@ -292,8 +275,6 @@ export function SettingsContextProvider({ children }: { children: ReactNode }) {
     executionFeeBufferBps,
     setExecutionFeeBufferBps,
     shouldUseExecutionFeeBuffer,
-    oracleKeeperInstancesConfig,
-    setOracleKeeperInstancesConfig,
     savedAcceptablePriceImpactBuffer,
     setSavedAcceptablePriceImpactBuffer,
     savedShowPnlAfterFees,

src/context/SyntheticsStateContext/hooks/settingsHooks.ts

@@ -1,12 +1,10 @@
 import {
   selectDebugSwapMarketsConfig,
   selectExecutionFeeBufferBps,
-  selectOracleKeeperInstancesConfig,
   selectSavedAcceptablePriceImpactBuffer,
   selectSavedAllowedSlippage,
   selectSetDebugSwapMarketsConfig,
   selectSetExecutionFeeBufferBps,
-  selectSetOracleKeeperInstancesConfig,
   selectSetSavedAcceptablePriceImpactBuffer,
   selectSetSavedAllowedSlippage,
   selectSetShowDebugValues,
@@ -24,7 +22,5 @@ export const useSetExecutionFeeBufferBps = () => useSelector(selectSetExecutionF
 export const useSavedAcceptablePriceImpactBuffer = () => useSelector(selectSavedAcceptablePriceImpactBuffer);
 export const useSetSavedAcceptablePriceImpactBuffer = () => useSelector(selectSetSavedAcceptablePriceImpactBuffer);
 export const useShouldUseExecutionFeeBuffer = () => useSelector(selectShouldUseExecutionFeeBuffer);
-export const useOracleKeeperInstancesConfig = () => useSelector(selectOracleKeeperInstancesConfig);
-export const useSetOracleKeeperInstancesConfig = () => useSelector(selectSetOracleKeeperInstancesConfig);
 export const useDebugSwapMarketsConfig = () => useSelector(selectDebugSwapMarketsConfig);
 export const useSetDebugSwapMarketsConfig = () => useSelector(selectSetDebugSwapMarketsConfig);

src/context/SyntheticsStateContext/selectors/settingsSelectors.ts

@@ -13,8 +13,6 @@ export const selectSavedAcceptablePriceImpactBuffer = (s: SyntheticsState) =>
 export const selectSetSavedAcceptablePriceImpactBuffer = (s: SyntheticsState) =>
   s.settings.setSavedAcceptablePriceImpactBuffer;
 export const selectShouldUseExecutionFeeBuffer = (s: SyntheticsState) => s.settings.shouldUseExecutionFeeBuffer;
-export const selectOracleKeeperInstancesConfig = (s: SyntheticsState) => s.settings.oracleKeeperInstancesConfig;
-export const selectSetOracleKeeperInstancesConfig = (s: SyntheticsState) => s.settings.setOracleKeeperInstancesConfig;
 export const selectIsPnlInLeverage = (s: SyntheticsState) => s.settings.isPnlInLeverage;
 export const selectShowPnlAfterFees = (s: SyntheticsState) => s.settings.showPnlAfterFees;
 export const selectIsLeverageSliderEnabled = (s: SyntheticsState) => s.settings.isLeverageSliderEnabled;

src/domain/synthetics/orders/simulation.ts

@@ -8,6 +8,7 @@ import {
   getMulticallContract,
   getZeroAddressContract,
 } from "config/contracts";
+import { isDevelopment } from "config/env";
 import { isGlvEnabled } from "domain/synthetics/markets/glv";
 import { SwapPricingType } from "domain/synthetics/orders";
 import { TokenPrices, TokensData, convertToContractPrice, getTokenData } from "domain/synthetics/tokens";
@@ -19,7 +20,6 @@ import { abis } from "sdk/abis";
 import { convertTokenAddress } from "sdk/configs/tokens";
 import { CustomErrorName, ErrorData, TxErrorType, extendError, isContractError, parseError } from "sdk/utils/errors";
 import { CreateOrderTxnParams, ExternalCallsPayload } from "sdk/utils/orderTransactions";
-import { isDevelopment } from "config/env";
 
 export type SimulateExecuteParams = {
   account: string;

src/lib/oracleKeeperFetcher/oracleKeeperFetcher.ts

@@ -1,6 +1,8 @@
+import random from "lodash/random";
+
 import { isLocal } from "config/env";
 import { Bar, FromNewToOldArray } from "domain/tradingview/types";
-import { getOracleKeeperNextIndex, getOracleKeeperUrl } from "sdk/configs/oracleKeeper";
+import { getOracleKeeperFallbackUrls, getOracleKeeperUrl } from "sdk/configs/oracleKeeper";
 import { getNormalizedTokenSymbol } from "sdk/configs/tokens";
 import { buildUrl } from "sdk/utils/buildUrl";
 
@@ -27,58 +29,54 @@ function parseOracleCandle(rawCandle: number[]): Bar {
   };
 }
 
-let fallbackThrottleTimerId: any;
+const failsPerMinuteToFallback = 5;
 
 export class OracleKeeperFetcher implements OracleFetcher {
   private readonly chainId: number;
-  private readonly oracleKeeperIndex: number;
-  private readonly setOracleKeeperInstancesConfig?: (
-    setter: (old: { [chainId: number]: number } | undefined) => {
-      [chainId: number]: number;
-    }
-  ) => void;
-  public readonly url: string;
-  private readonly forceIncentivesActive: boolean;
 
-  constructor(p: {
-    chainId: number;
-    oracleKeeperIndex: number;
-    setOracleKeeperInstancesConfig?: (
-      setter: (old: { [chainId: number]: number } | undefined) => {
-        [chainId: number]: number;
-      }
-    ) => void;
-    forceIncentivesActive: boolean;
-  }) {
+  private readonly forceIncentivesActive: boolean;
+  private isFallback: boolean;
+  private fallbackUrls: string[];
+  private fallbackThrottleTimerId: number | undefined;
+  private fallbackIndex: number;
+  private failTimes: number[];
+  private mainUrl: string;
+
+  constructor(p: { chainId: number; forceIncentivesActive: boolean }) {
     this.chainId = p.chainId;
-    this.oracleKeeperIndex = p.oracleKeeperIndex;
-    this.setOracleKeeperInstancesConfig = p.setOracleKeeperInstancesConfig;
-    this.url = getOracleKeeperUrl(this.chainId, this.oracleKeeperIndex);
+    this.fallbackUrls = getOracleKeeperFallbackUrls(this.chainId);
+    this.mainUrl = getOracleKeeperUrl(this.chainId);
     this.forceIncentivesActive = p.forceIncentivesActive;
+    this.isFallback = false;
+    this.failTimes = [];
+  }
+
+  get url() {
+    return this.isFallback ? this.fallbackUrls[this.fallbackIndex] : this.mainUrl;
   }
 
-  switchOracleKeeper() {
-    if (fallbackThrottleTimerId || !this.setOracleKeeperInstancesConfig) {
+  handleFailure() {
+    if (this.fallbackThrottleTimerId) {
       return;
     }
 
-    const nextIndex = getOracleKeeperNextIndex(this.chainId, this.oracleKeeperIndex);
+    this.failTimes.push(Date.now());
 
-    if (nextIndex === this.oracleKeeperIndex) {
-      // eslint-disable-next-line no-console
-      console.error(`no available oracle keeper for chain ${this.chainId}`);
-      return;
-    }
+    this.failTimes = this.failTimes.filter((time) => time > Date.now() - 60000);
 
-    // eslint-disable-next-line no-console
-    console.log(`switch oracle keeper to ${getOracleKeeperUrl(this.chainId, nextIndex)}`);
+    if (this.failTimes.length >= failsPerMinuteToFallback) {
+      if (this.isFallback) {
+        this.fallbackIndex = (this.fallbackIndex + 1) % this.fallbackUrls.length;
+      } else {
+        this.fallbackIndex = random(0, this.fallbackUrls.length - 1);
+      }
 
-    this.setOracleKeeperInstancesConfig((old) => {
-      return { ...old, [this.chainId]: nextIndex };
-    });
+      this.isFallback = true;
+      this.failTimes = [];
+    }
 
-    fallbackThrottleTimerId = setTimeout(() => {
-      fallbackThrottleTimerId = undefined;
+    this.fallbackThrottleTimerId = window.setTimeout(() => {
+      this.fallbackThrottleTimerId = undefined;
     }, 5000);
   }
 
@@ -95,7 +93,7 @@ export class OracleKeeperFetcher implements OracleFetcher {
       .catch((e) => {
         // eslint-disable-next-line no-console
         console.error(e);
-        this.switchOracleKeeper();
+        this.handleFailure();
 
         throw e;
       });
@@ -114,7 +112,7 @@ export class OracleKeeperFetcher implements OracleFetcher {
       .catch((e) => {
         // eslint-disable-next-line no-console
         console.error(e);
-        this.switchOracleKeeper();
+        this.handleFailure();
         throw e;
       });
   }
@@ -164,7 +162,7 @@ export class OracleKeeperFetcher implements OracleFetcher {
       .catch((e) => {
         // eslint-disable-next-line no-console
         console.error(e);
-        this.switchOracleKeeper();
+        this.handleFailure();
         throw e;
       });
   }
@@ -184,7 +182,7 @@ export class OracleKeeperFetcher implements OracleFetcher {
       .catch((e) => {
         // eslint-disable-next-line no-console
         console.error(e);
-        this.switchOracleKeeper();
+        this.handleFailure();
         throw e;
       });
   }
@@ -199,7 +197,7 @@ export class OracleKeeperFetcher implements OracleFetcher {
       .catch((e) => {
         // eslint-disable-next-line no-console
         console.error(e);
-        this.switchOracleKeeper();
+        this.handleFailure();
         return null;
       });
   }

src/lib/oracleKeeperFetcher/useOracleKeeperFetcher.ts

@@ -1,22 +1,21 @@
 import { useMemo } from "react";
 
-import { useSettings } from "context/SettingsContext/SettingsContextProvider";
 import { useLocalStorageSerializeKey } from "lib/localStorage";
 import { OracleFetcher, OracleKeeperFetcher } from "lib/oracleKeeperFetcher";
 
+const oracleKeeperFetchersCached: Record<number, OracleFetcher> = {};
+
 export function useOracleKeeperFetcher(chainId: number): OracleFetcher {
-  const { oracleKeeperInstancesConfig, setOracleKeeperInstancesConfig } = useSettings();
-  const oracleKeeperIndex = oracleKeeperInstancesConfig?.[chainId] ?? 0;
   const [forceIncentivesActive] = useLocalStorageSerializeKey([chainId, "forceIncentivesActive"], false);
 
   return useMemo(() => {
-    const instance = new OracleKeeperFetcher({
-      chainId,
-      oracleKeeperIndex,
-      forceIncentivesActive: Boolean(forceIncentivesActive),
-      setOracleKeeperInstancesConfig,
-    });
+    if (!oracleKeeperFetchersCached[chainId]) {
+      oracleKeeperFetchersCached[chainId] = new OracleKeeperFetcher({
+        chainId,
+        forceIncentivesActive: Boolean(forceIncentivesActive),
+      });
+    }
 
-    return instance;
-  }, [chainId, forceIncentivesActive, oracleKeeperIndex, setOracleKeeperInstancesConfig]);
+    return oracleKeeperFetchersCached[chainId];
+  }, [chainId, forceIncentivesActive]);
 }