Update: update etherscan url to v2 from v1 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnpar
requested changes
May 21, 2025
src/ethproto/wrappers.py
Outdated
| ETHERSCAN_TOKEN = env.str("ETHERSCAN_TOKEN", None) | ||
| ETHERSCAN_DOMAIN = env.str("ETHERSCAN_DOMAIN", "api.etherscan.io") | ||
| ETHERSCAN_URL = env.str("ETHERSCAN_URL", "https://{domain}/api?apikey={token}&") | ||
| ETHERSCAN_URL = env.str("ETHERSCAN_URL", "https://{domain}/v2/api?apikey={token}&") |
Collaborator
There was a problem hiding this comment.
Acá ya tendría que incluir el chainId también. Que get_etherscan_url lo complete.
tests/test_w3.py
Outdated
| mocker.patch.dict( | ||
| os.environ, | ||
| { | ||
| "ETHERSCAN_URL": "https://{domain}/v2/api?apikey={token}&", |
Collaborator
There was a problem hiding this comment.
Mejor no sobreescribir la URL para el test, podría enmascarar errores (o cambios que rompen compatibilidad en el futuro)
tox.ini
Outdated
| testing | ||
| deps = | ||
| warrant @ git+https://github.com/gnarvaja/warrant.git#egg=warrant | ||
| requests-mock |
Collaborator
There was a problem hiding this comment.
Por qué esta dependencia que no usamos en ningún lado? Usemos responses. Además la dependencia habría que ponerla en setup.cfg, en la sección de testing.
Si no podés usar cassete (pytest-recording) que ya está incluida, pero capaz para este caso es mejor responses.
…et url to use chainid
gnarvaja
approved these changes
May 22, 2025
gnpar
reviewed
May 22, 2025
src/ethproto/wrappers.py
Outdated
| if ETHERSCAN_TOKEN is None: | ||
| return None | ||
| return ETHERSCAN_URL.format(token=ETHERSCAN_TOKEN, domain=ETHERSCAN_DOMAIN) | ||
| return ETHERSCAN_URL.format(token=ETHERSCAN_TOKEN, domain=ETHERSCAN_DOMAIN, chainid=ETHERSCAN_CHAIN) |
Collaborator
There was a problem hiding this comment.
Para mi estaba bien como lo hacia antes, que lo tomaba de self.w3.chain_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.