Raise error messages using custom errors #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for custom errors in base contracts: ERC20, ERC721 and AccessControl
LucasCambon
approved these changes
Aug 21, 2025
Comment on lines
545
to
582
| def _error(self, error_class, *args) -> RevertError: | ||
| if error_class == "ERC721InvalidOwner": | ||
| if self.use_custom_errors: | ||
| return RevertCustomError( | ||
| error_class, args[0] if args else "0x0000000000000000000000000000000000000000" | ||
| ) | ||
| else: | ||
| return RevertError("ERC721: address zero is not a valid owner") | ||
| elif error_class == "ERC721NonexistentToken": | ||
| if self.use_custom_errors: | ||
| return RevertCustomError(error_class, args[0]) | ||
| else: | ||
| return RevertError("ERC721: invalid token ID") | ||
| elif error_class == "ERC721IncorrectOwner": | ||
| if self.use_custom_errors: | ||
| return RevertCustomError(error_class, args[0], args[1], args[2]) | ||
| else: | ||
| return RevertError("ERC721: transfer from incorrect owner") | ||
| elif error_class == "ERC721InvalidSender": | ||
| if self.use_custom_errors: | ||
| return RevertCustomError( | ||
| error_class, args[0] if args else "0x0000000000000000000000000000000000000000" | ||
| ) | ||
| else: | ||
| return RevertError("ERC721: transfer from incorrect owner") | ||
| elif error_class == "ERC721InvalidReceiver": | ||
| if self.use_custom_errors: | ||
| return RevertCustomError( | ||
| error_class, args[0] if args else "0x0000000000000000000000000000000000000000" | ||
| ) | ||
| else: | ||
| return RevertError("ERC721: transfer to the zero address") | ||
| elif error_class == "ERC721InsufficientApproval": | ||
| if self.use_custom_errors: | ||
| return RevertCustomError(error_class, args[0], args[1]) | ||
| else: | ||
| return RevertError("ERC721: caller is not token owner nor approved") | ||
| return super()._error(error_class, *args) |
Collaborator
There was a problem hiding this comment.
Podría aplicar acá lo mismo que decía arriba, solo si la opción del mapping es viable.
Thanks @LucasCambon for the review, now with less code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for custom errors in base contracts: ERC20, ERC721 and AccessControl