Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kb/printer/style.py #109

Merged
merged 1 commit into from
Oct 17, 2023
Merged

kb/printer/style.py #109

merged 1 commit into from
Oct 17, 2023

Conversation

GasparVardanyan
Copy link

What does this implement/fix? Explain your changes.

...
Maybe python-colored is updated and changed the parameter name from 'underlined' to 'underline'
Does this close any currently open issues?

...

Any relevant logs, error output, etc?

Traceback (most recent call last):
  File "/home/gaspar/testenv/bin/kb", line 5, in <module>
    from kb.main import main
  File "/home/gaspar/testenv/lib/python3.11/site-packages/kb/main.py", line 20, in <module>
    from kb.commands.search import search
  File "/home/gaspar/testenv/lib/python3.11/site-packages/kb/commands/search.py", line 17, in <module>
    import kb.printer.search as printer
  File "/home/gaspar/testenv/lib/python3.11/site-packages/kb/printer/search.py", line 15, in <module>
    from kb.printer.style import ALT_BGROUND, BOLD, UND, RESET
  File "/home/gaspar/testenv/lib/python3.11/site-packages/kb/printer/style.py", line 20, in <module>
    UND = styler.set_style('underlined')
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/gaspar/testenv/lib/python3.11/site-packages/kb/styler.py", line 59, in set_style
    return colored.attr(style)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/gaspar/testenv/lib/python3.11/site-packages/colored/colored.py", line 263, in attr
    return Colored(name).attribute()
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/gaspar/testenv/lib/python3.11/site-packages/colored/colored.py", line 64, in attribute
    self._utils.is_style_exist(self._name)
  File "/home/gaspar/testenv/lib/python3.11/site-packages/colored/utilities.py", line 53, in is_style_exist
    raise InvalidStyle(f'{InvalidStyle.__name__}: {name}')
colored.exceptions.InvalidStyle: InvalidStyle: underlined

Any other comments?

...

Where has this been tested?

Operating System: ArchLinux

Platform: x64

Target Platform: what is this?

@lewis262626
Copy link

The requirements.txt file should be using semver to pin dependencies tbh. It should stop this from happening in the future.

@gnebbia gnebbia merged commit 862a1ab into gnebbia:main Oct 17, 2023
@gnebbia
Copy link
Owner

gnebbia commented Oct 17, 2023

thanks for the PR and sorry for the delay!
Yes I will switch to semantic versioning for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants