Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed attr and attrs dependency from main version #82

Closed
wants to merge 3 commits into from
Closed

Removed attr and attrs dependency from main version #82

wants to merge 3 commits into from

Conversation

Fearkin
Copy link

@Fearkin Fearkin commented Mar 27, 2021

What does this implement/fix? Explain your changes.

Solves this problem (https://github.com/gnebbia/kb/projects/4) via dataclasses from standard library instead of attr. Now only pytest from requirements-dev depends on attrs and attr.

Does this close any currently open issues?

Prevents this (#76) type of issues

Any relevant logs, error output, etc?

I've ran into same issue that I mentioned above (and I had same error) and this fix worked for me

Any other comments?

I've also autoformatted many files

Where has this been tested?

All tests passed
Operating System: Manjaro 21.0 Ornara (Linux 5.9.16-1-MANJARO)

Platform: Python 3.9.2, kb 0.1.6

@gnebbia
Copy link
Owner

gnebbia commented Mar 27, 2021

Dear Sir, thanks for the suggestion, but is this compatible with all pythons from 3.6?

@Fearkin
Copy link
Author

Fearkin commented Mar 27, 2021

Dear Sir, thanks for the suggestion, but is this compatible with all pythons from 3.6?

As far as I know, data classes were introduced in version 3.7, so they will not work in versions below this one :(

@gnebbia
Copy link
Owner

gnebbia commented Mar 27, 2021

That may be a problem, since the minimum version supported is python 3.6, what do you suggest?

@Fearkin
Copy link
Author

Fearkin commented Mar 27, 2021

That may be a problem, since the minimum version supported is python 3.6, what do you suggest?

What if I try to port dataclasses for version 3.6 via (https://pypi.org/project/dataclasses/) and some version check?

@gnebbia
Copy link
Owner

gnebbia commented Mar 27, 2021

Correct me if I am wrong, but at this point the dependency would be dataclass instead of attr, I mean we still would have one.

@Fearkin
Copy link
Author

Fearkin commented Mar 27, 2021

Correct me if I am wrong, but at this point the dependency would be dataclass instead of attr, I mean we still would have one.

I meant version check on setup too, so we can install this specific package only for 3.6

@gnebbia
Copy link
Owner

gnebbia commented Mar 27, 2021

Yes if there such thing we may try, although I also have to deal with PKGBUILDs for arch, and should check out how to specify that

@gnebbia gnebbia closed this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants