Fix gnebbia/kb#83 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix problem with spaces in artifact title when using grep command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem with spaces in artifact title when using grep command.
What does this implement/fix? Explain your changes.
This fixes the issue #83 of the grep command crashing with an IndexError when artifact titles contain spaces. If an artifact's title contains spaces get_file_name_wo_prefix() parses the artifact title incorrectly.
The following call to db_get_artifacts_by_filter() returns no results because all but the last parts of the title are incorporated into the category parameter. When the code tries to extract the (non-existen) result, an index error is raised.
A detailed description of the issue can be found here
The fix uses the standard library class pathlib.Path for prefix removal and parsing of path components.
Does this close any currently open issues?
It is supposed to fix #83.
Any relevant logs, error output, etc?
...
Any other comments?
...
Where has this been tested?
Operating System: linux, ubuntu 18.04
Platform: x86_64
Target Platform: x86_64/windows