feat: transpile to Gno 0.9 (latest interrealm spec) with @cross #4264

jaekwon · 2025-05-10T09:37:38Z

WIP

Gno2D2 · 2025-05-10T09:38:10Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

codecov · 2025-05-10T09:41:48Z

Codecov Report

Attention: Patch coverage is 53.94372% with 1162 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/transpile_gno0p9.go	12.74%	363 Missing ⚠️
gnovm/cmd/gno/tool_fix.go	5.83%	257 Missing and 1 partial ⚠️
gnovm/cmd/gno/common.go	46.60%	101 Missing and 9 partials ⚠️
gnovm/pkg/gnolang/preprocess.go	83.66%	64 Missing and 17 partials ⚠️
gnovm/pkg/gnolang/mempackage.go	35.29%	38 Missing and 17 partials ⚠️
gnovm/pkg/gnolang/nodes_span.go	61.06%	40 Missing and 4 partials ⚠️
gnovm/pkg/gnolang/gotypecheck.go	79.45%	29 Missing and 9 partials ⚠️
gnovm/cmd/gno/tool_lint.go	74.01%	24 Missing and 9 partials ⚠️
gnovm/pkg/gnolang/gnomod.go	62.92%	22 Missing and 11 partials ⚠️
gnovm/pkg/gnolang/nodes.go	71.42%	23 Missing and 5 partials ⚠️
... and 18 more

📢 Thoughts on this report? Let us know!

gnovm/pkg/gnolang/version.go

moul · 2025-05-12T08:02:15Z

examples/gno.land/r/gov/dao/v3/memberstore/memberstore_test.gno

@@ -115,7 +114,7 @@ func TestCreateMembers(t *testing.T) {
 }

 func addMembers(ms MembersByTier, c int, tier string) {
-	mt := avl.NewTree()
+	// mt := avl.NewTree() XXX


examples *_test.gno files were never type-checked, and mt isn't used.

moul · 2025-05-12T08:07:55Z

tm2/pkg/std/memfile.go

+// File Name must contain a single dot and extension.
+// File Name may be ALLCAPS.xxx or lowercase.xxx; extensions lowercase.
+// e.g. OK:     README.md, readme.md, readme.txt, READ.me
+// e.g. NOT OK: Readme.md, readme.MD, README, .readme


Suggested change

// e.g. NOT OK: Readme.md, readme.MD, README, .readme

// e.g. NOT OK: Readme.md, readme.MD, README.md, .readme

README.md is OK. README is not.

moul · 2025-05-12T08:09:10Z

tm2/pkg/std/memfile.go

 	"sort"
 	"strings"
 )

+// XXX rename to mempackage.go
+
+const fileNameLimit = 256


Can we consider a lower limit, especially since it's only the file part that can be added to an already long path or URL?
Maybe in gnovm's additional validation logic.

tm2/pkg/std/memfile.go

…4264

Signed-off-by: moul <[email protected]>

thehowl

Still reading through, some initial comments.

thehowl · 2025-05-21T21:40:39Z

gnovm/pkg/gnolang/gnomod.go

Does this have to be in the same package as gnolang?

should be close to filenode, and gnovm specific mempackage logic; and gnovm/pkg/gnomod should be its dependency. It should really be part of the PackageNode, so yes.

thehowl · 2025-05-21T21:42:45Z

gnovm/pkg/gnolang/files_test.go

+		subTestName := path
+		isHidden := strings.HasPrefix(path, ".")
+		if isHidden {
+			t.Run(subTestName, func(t *testing.T) {
+				t.Skip("skipping hidden")
+			})
+			return nil
+		}
 		isLong := strings.HasSuffix(path, "_long.gno")
 		if isLong && testing.Short() {
 			t.Run(subTestName, func(t *testing.T) {
-				t.Skip("skipping in -short")
+				t.Skip("skipping long (-short)")


could determine a skipReason first and then do t.Run with skip if given maybe. would avoid. also we don't need a subTestName anymore, we can just use path

thehowl · 2025-05-21T21:46:04Z

gnovm/pkg/gnolang/go2gno.go

What justifies changing these into spans?

I think it makes the error formats different and harder to integrate into ie. text editors (a lot of editors now understand file:line:col: and make them clickable) and unintuitive to use compared to what folks are used to, while adding little information.

I think what we really need is to add more information to the errors that require it.

Nodes can have the same starting position. C(X)(Y(Z())) <-- C, C(X), C(X)(...) are all in the same location.
If you want to do transforms on them, or do any sort of lookup, you can't do so with just the file:line:col. This was needed in gno fix because I want to use the gno type information from the preprocessor, but the gno AST doesn't print/fmt well, so instead the desired transforms are written by file:span, and then translated to actual Go AST node references, and then finally astutil.Apply does Go AST mutations. Along the way I found the need for spans for debugging due to the potential redundancy.

It's easy enough to filter these and strip the unwanted portion of a span. It adds little but necessary information; without it, it cannot serve as an identifier for the node.

If an IDE wants to highlight a selection of text and show the error next to it, it needs the span, again because of the redundancy issue. Existing text editors are just less informative than they should be, and the gnovm doesn't make compromises for the past 30 years of tooling, because it's meant for the next 1000.

thehowl · 2025-05-21T21:49:30Z

gnovm/stdlibs/testing/base/README.md

The fact that this is necessary indicates to me there's likely a bug in the typechecker, no?

We should be able to break these cycles with test if we have xxx_test files.

I'm not sure what you're referring to, but the typechecker was buggy with respect to _tests and _filetests, and it wasn't showing because type-checking wasn't being performed on testfiles and filetests.

moul · 2025-05-22T14:18:47Z

contribs/gnodev/pkg/packages/package.go

+	for _, file := range mempkg.Files {
+		if isGnoFile(file.Name) || file.Name == "gno.mod" {
+			return false
+		}
+	}


looks like an helper we also want in gno, maybe IsGnoMempackageEmpty().

Co-authored-by: Manfred Touron <[email protected]>

odeke-em · 2025-05-25T21:44:49Z

contribs/gnodev/pkg/packages/package.go

-	if err != nil {
-		return false, fmt.Errorf("unable to parse `gno.mod`: %w", err)
+	for _, file := range mempkg.Files {
+		if isGnoFile(file.Name) || file.Name == "gno.mod" {


I realize that this is a heuristic but this can be made much more robust by also os.Stat and then checking if fi.Size() > 0, otherwise a mem package with zero sized .gno or .mod files will return false @moul @jaekwon @thehowl

This is gnodev, not gnovm or gno.land. In my opinion, we should perform minimal checks here unless we want to log something for the user, as this could lead to duplicate logic. Robust checks should happen behind when triggering AddPackage.

jaekwon added 5 commits May 8, 2025 18:29

add xform

619bddb

add preprocess2 and hack lint

b6a4de8

...

dc00ab6

refactor

cc0842f

gnomod/lint/transpile etc

32e2e78

github-project-automation bot moved this to Triage in 🧙‍♂️gno.land core team May 10, 2025

github-project-automation bot added this to 💪 Bounties & Worx and 🧙‍♂️gno.land core team May 10, 2025

github-actions bot assigned jaekwon May 10, 2025

github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels May 10, 2025

improve flow and documentation

17faaca

moul reviewed May 10, 2025

View reviewed changes

gnovm/pkg/gnolang/version.go Outdated Show resolved Hide resolved

moul mentioned this pull request May 10, 2025

WIP feat(modfile): switch to gnomod.toml v1 #4263

Draft

17 tasks

jaekwon added 4 commits May 10, 2025 13:06

gimp

4fc804c

fix multi error passthrough

77e5e28

added adr/lint_transpile.md; naming fixes; lint/test works

4911675

...

56b6cdb

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels May 11, 2025

jaekwon added 3 commits May 11, 2025 20:03

xpiling works ish

cbba489

...

7cf9fc1

...

07086ad

moul reviewed May 12, 2025

View reviewed changes

tm2/pkg/std/memfile.go Outdated Show resolved Hide resolved

moul reviewed May 12, 2025

View reviewed changes

tm2/pkg/std/memfile.go Outdated Show resolved Hide resolved

gfanton and others added 11 commits May 21, 2025 10:13

fix: gnodev

2b8794e

fix: keeper load

c3ed31f

...

371d6a2

...

136e0fe

property sort normal/_test/filetests

8fd6cb5

type-check fix examples more

28f6382

fix one r/leon/hor test

76fb198

Merge commit 'refs/pull/4264/head' of github.com:gnolang/gno into pr-…

afbac72

…4264

fix import name issue

54bc6eb

chore(examples): add 'make fix'

3becb1c

Signed-off-by: moul <[email protected]>

p/*_test.gno can import r/

6b551a4

Signed-off-by: moul <[email protected]>

thehowl reviewed May 21, 2025

View reviewed changes

jaekwon and others added 3 commits May 21, 2025 23:51

validate mempackage

09fa106

fix(gnodev): validate mpkg function

d9ee35a

fix: add ParseMode argument to TypeCheckMemPackage

82efcb3

moul reviewed May 22, 2025

View reviewed changes

jaekwon and others added 5 commits May 22, 2025 22:26

fix gno lint xxx_test

51635be

chore: lint

c604710

chore: lint pt2

3ca93f7

fix: integration gas update

c673fd1

Apply suggestions from code review

2cc60ed

Co-authored-by: Manfred Touron <[email protected]>

jaekwon force-pushed the fix/crossrealm/xform branch from 8467591 to 2cc60ed Compare May 24, 2025 09:11

jaekwon added 3 commits May 24, 2025 02:14

Merge remote-tracking branch 'origin/master' into fix/crossrealm/xform

385d108

let file names have some more dots

075b205

...

40a1c61

jaekwon merged commit c0b0f86 into master May 24, 2025
26 of 34 checks passed

jaekwon deleted the fix/crossrealm/xform branch May 24, 2025 09:27

github-project-automation bot moved this to Done in 💪 Bounties & Worx May 24, 2025

github-project-automation bot moved this from In Review to Done in 🧙‍♂️gno.land core team May 24, 2025

odeke-em reviewed May 25, 2025

View reviewed changes

	// e.g. NOT OK: Readme.md, readme.MD, README, .readme
	// e.g. NOT OK: Readme.md, readme.MD, README.md, .readme

feat: transpile to Gno 0.9 (latest interrealm spec) with @cross #4264

feat: transpile to Gno 0.9 (latest interrealm spec) with @cross #4264

Conversation

jaekwon commented May 10, 2025

Uh oh!

Gno2D2 commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Can be checked by

Uh oh!

codecov bot commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moul May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thehowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gfanton May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Gno2D2 commented May 10, 2025 •

edited

Loading

codecov bot commented May 10, 2025 •

edited

Loading

moul May 12, 2025 •

edited

Loading

gfanton May 26, 2025 •

edited

Loading