Skip to content

feat(commondao): add common proposal types to realm #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeronimoalbi
Copy link
Member

@jeronimoalbi jeronimoalbi commented May 16, 2025

The following proposal types were added:

  • General (text) proposal type
  • New SubDAO proposal type
  • Dismiss DAO proposal type
  • DAO members update proposal

Changeset also adds TX links to create proposals of these types to DAO views.

Any dApp using the commondao realm can optionally enable any of these proposal types so users can create them though the commondao realm. By default they are not enabled making it an opt-in feature for cases where dApps don't want to implement these common proposal types within their realms.

@jeronimoalbi
Copy link
Member Author

Leaving PR as draft until #4270 is merged

@Gno2D2
Copy link
Collaborator

Gno2D2 commented May 16, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Base automatically changed from feat/jeronimoalbi/commondao-realm-render to master May 22, 2025 16:38
@jeronimoalbi jeronimoalbi force-pushed the feat/jeronimoalbi/commondao-realm-proposals branch from e87f542 to e313952 Compare May 22, 2025 17:43
The following proposal types were added:
- General (text) proposal type
- New SubDAO proposal type
- Dismiss DAO proposal type
- DAO members update proposal

Changeset also adds TX links to create proposals of these types to DAO
views.
@jeronimoalbi jeronimoalbi reopened this May 22, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in 💪 Bounties & Worx May 22, 2025
@jeronimoalbi jeronimoalbi marked this pull request as ready for review May 22, 2025 17:57
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label May 22, 2025
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label May 23, 2025
@Kouteki Kouteki moved this from Todo to In Review in 🧙‍♂️gno.land core team Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants