-
Notifications
You must be signed in to change notification settings - Fork 413
feat(commondao): add common proposal types to realm #4286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Leaving PR as draft until #4270 is merged |
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Pending initial approval by a review team member, or review from tech-staff ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
e87f542
to
e313952
Compare
The following proposal types were added: - General (text) proposal type - New SubDAO proposal type - Dismiss DAO proposal type - DAO members update proposal Changeset also adds TX links to create proposals of these types to DAO views.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following proposal types were added:
Changeset also adds TX links to create proposals of these types to DAO views.
Any dApp using the
commondao
realm can optionally enable any of these proposal types so users can create them though thecommondao
realm. By default they are not enabled making it an opt-in feature for cases where dApps don't want to implement these common proposal types within their realms.