feat(govdao): add proposal fee-based for non-member #4944

Davphla · 2025-12-07T13:31:19Z

I set an arbitrary fee of 1_000_000 ugnot for a non member proposal.
Coins are stored in GovDAO implementation, and can be use by the DAO.
I've removed invitation point on NewMemberProposalRequest, as it doesn't really make sense anymore. Though it is still necessary in AddMember.

Outside of the test files, it is not testable.
See #4866

Gno2D2 · 2025-12-07T13:31:44Z

🛠 PR Checks Summary

🔴 Pending initial approval by a review team member, or review from tech-staff

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: Davphla/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🔴 Requirement not satisfied
└── 🔴 If
    ├── 🔴 Condition
    │   └── 🔴 Or
    │       ├── 🔴 At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🔴 Else
        └── 🔴 And
            ├── 🟢 This label is applied to pull request: review/triage-pending
            └── 🔴 On no pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

codecov · 2025-12-07T13:32:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

examples/gno.land/r/gov/dao/v3/impl/govdao.gno

MikaelVallenet · 2025-12-11T10:16:16Z

examples/gno.land/r/gov/dao/v3/impl/govdao_test.gno

+
+	// Test: Non-member with insufficient fee should also fail with realm validation error
+	testing.SetOriginSend(chain.Coins{chain.Coin{Denom: "ugnot", Amount: 500000}}) // 0.5 GNOT - insufficient
+	uassert.AbortsContains(t, "proposal creation must be done directly by a user or through the r/gov/dao proxy", func(cur realm) {


why the error here should say "proposal creation must be done directly by a user or through the r/gov/dao proxy", i would expect the test to ensure there is a "insufficient fee, user must send 1_000_000 gnot" or smth like this, same for all your test in this function.

Fix: 856c91e

MikaelVallenet · 2025-12-11T10:19:00Z

examples/gno.land/r/gov/dao/v3/impl/prop_requests.gno

-	if member.InvitationPoints <= 0 {
-		panic("proposer does not have enough invitation points for inviting new people to the board")
-	}


for me this line should never have been there, invitations point should be only for the T3 AddMember function but since it was here it makes me wondering if we should keep it in case the proposal is coming from a member ?

I agree, in the end this is just a helper function to create a ProposalRequest object, any non-member could bypass this condition by creating their own ProposalRequest object.
But I don't think we should keep it as it is not protective, or we should rethink how invitationPoint work in GovDAO.

MikaelVallenet · 2025-12-11T10:20:03Z

examples/gno.land/r/gov/dao/v3/impl/govdao.gno

 var ErrMemberNotFound = errors.New("member not found")

+// ProposalFeeAmount is the fee required for non-members to create proposals (in ugnot)
+const ProposalFeeAmount int64 = 1000000 // 1 GNOT


should we create a new helper function to create a proposal request containing the executor callback to update this number ?

Fix: 856c91e

Co-authored-by: MikaelVallenet <[email protected]>

… for non-members + fix tests

MikaelVallenet · 2025-12-11T21:00:53Z

examples/gno.land/r/gov/dao/v3/impl/prop_requests.gno

+func NewProposalFeeAmountRequest(newAmount int64, reason string) dao.ProposalRequest {
+	if newAmount < 0 {
+		panic("proposal fee amount must be non-negative")
+	}
+
+	if reason == "" {
+		panic("proposal fee amount change requires a reason")
+	}


i think we should add a txtar test flow of changing the proposal fee else the PR looks good to me i will approve once this done

github-project-automation bot added this to 💪 Bounties & Worx and 🧙‍♂️Gno.land development Dec 7, 2025

github-project-automation bot moved this to Triage in 🧙‍♂️Gno.land development Dec 7, 2025

Davphla marked this pull request as draft December 7, 2025 13:31

github-actions bot assigned Davphla Dec 7, 2025

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Dec 7, 2025

Davphla force-pushed the feat/govdao-fee branch from c0302d5 to ea1804b Compare December 7, 2025 15:40

Davphla added 3 commits December 7, 2025 16:41

feat(govdao): made r/gov/dao proposals fee-based for non-members

ea1804b

fix(govdao): remove unecessary comment addition

19a819a

feat(govdao): replace AbortsWithMessage with AbortsContains

640b24f

github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Dec 7, 2025

Davphla added 2 commits December 7, 2025 17:02

fix(govdao): update error message for non-member proposal creation

a75dd70

refactor(render): more consistent MembershipBadge usage

1dcd085

Davphla marked this pull request as ready for review December 7, 2025 16:41

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 7, 2025

Davphla added this to FlashorgSprint: Gnocore Minicrew 🥷 Dec 7, 2025

Davphla moved this to NEED PEER REVIEW (INTERNAL) in FlashorgSprint: Gnocore Minicrew 🥷 Dec 7, 2025

Davphla removed this from FlashorgSprint: Gnocore Minicrew 🥷 Dec 7, 2025

fix(render): correct non-member badge test assertion

44d0a1b

Kouteki requested review from ajnavarro, moul and zivkovicmilos December 9, 2025 12:59

Kouteki moved this from Triage to In Review in 🧙‍♂️Gno.land development Dec 9, 2025

refactor(govdao): remove useless comment

75ca012

MikaelVallenet reviewed Dec 11, 2025

View reviewed changes

Davphla and others added 2 commits December 11, 2025 17:07

Update examples/gno.land/r/gov/dao/v3/impl/govdao.gno

3ac4368

Co-authored-by: MikaelVallenet <[email protected]>

feat(govdao): add functionality to set and update proposal fee amount…

856c91e

… for non-members + fix tests

Davphla requested a review from MikaelVallenet December 11, 2025 17:23

fix(test): remove unnecessary realm setting line

2d60019

MikaelVallenet reviewed Dec 11, 2025

View reviewed changes

feat(govdao): add proposal fee-based for non-member #4944

Are you sure you want to change the base?

feat(govdao): add proposal fee-based for non-member #4944

Uh oh!

Conversation

Davphla commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gno2D2 commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

Uh oh!

codecov bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

MikaelVallenet Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Davphla Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

MikaelVallenet Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Davphla Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MikaelVallenet Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Davphla Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

MikaelVallenet Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Davphla commented Dec 7, 2025 •

edited

Loading

Gno2D2 commented Dec 7, 2025 •

edited

Loading

codecov bot commented Dec 7, 2025 •

edited

Loading

Davphla Dec 11, 2025 •

edited

Loading

MikaelVallenet Dec 11, 2025 •

edited

Loading