Skip to content

fix(gnovm): inconsistency in the single-linked list implementation (cont.) #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Davphla wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix(gnovm): inconsistency in the single-linked list implementation (cont.) #4960

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
96781b2
fix(gnovm): incorrect append logic on initialized MapList
Davphla Dec 10, 2025
7162117
fix(gnovm): missing mapList size reset
Davphla Dec 10, 2025
858e76d
fix(gnovm): simplify MapList item initialization in Append method
Davphla Dec 10, 2025
1c81b95
fix(gnovm): revert to initial implementation
Davphla Dec 10, 2025
694ac44
fix(gnovm): revert to initial implementation
Davphla Dec 10, 2025
da34122
fix(gnovm): correct Prev pointer assignment in MapList Append method
Davphla Dec 10, 2025
bd5dcbb
fix(gnovm): revert to original
Davphla Dec 10, 2025
98d1357
Merge branch 'master' into fix/inconsistency-linked-list
Davphla Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions gnovm/pkg/gnolang/values.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,15 +657,16 @@ func (ml MapList) MarshalAmino() (MapListImage, error) {
func (ml *MapList) UnmarshalAmino(mlimg MapListImage) error {
for i, item := range mlimg.List {
if i == 0 {
item.Prev = nil
ml.Head = item
ml.Tail = item
item.Prev = nil
ml.Size = 1
} else {
item.Prev = ml.Tail
ml.Tail.Next = item
ml.Tail = item
ml.Size++
}
ml.Size++
}
return nil
}
Expand All @@ -682,15 +683,19 @@ func (ml *MapList) Append(alloc *Allocator, key TypedValue) *MapListItem {
if ml.Head == nil {
ml.Head = item
ml.Tail = item
ml.Size = 1
} else {
ml.Tail.Next = item
ml.Tail = item
ml.Size++
}
ml.Size++
return item
}

func (ml *MapList) Remove(mli *MapListItem) {
if ml.Size == 0 {
return
}
prev, next := mli.Prev, mli.Next
if prev == nil {
ml.Head = next
Expand Down
Loading