Skip to content

fix(gnovm): allow divisions by zero on floats #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thehowl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(gnovm): allow divisions by zero on floats #4961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions gnovm/pkg/gnolang/op_binary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,17 +889,10 @@ func quoAssign(lv, rv *TypedValue) *Exception {
lv.SetUint64(lv.GetUint64() / rv.GetUint64())
case Float32Type:
// NOTE: gno doesn't fuse *+.
ok := !softfloat.Feq32(rv.GetFloat32(), softfloat.Fintto32(0))

if ok {
lv.SetFloat32(softfloat.Fdiv32(lv.GetFloat32(), rv.GetFloat32()))
}
lv.SetFloat32(softfloat.Fdiv32(lv.GetFloat32(), rv.GetFloat32()))
case Float64Type:
// NOTE: gno doesn't fuse *+.
ok := !softfloat.Feq64(rv.GetFloat64(), softfloat.Fintto64(0))
if ok {
lv.SetFloat64(softfloat.Fdiv64(lv.GetFloat64(), rv.GetFloat64()))
}
lv.SetFloat64(softfloat.Fdiv64(lv.GetFloat64(), rv.GetFloat64()))
case UntypedBigintType:
if rv.GetBigInt().Sign() == 0 {
return expt
Expand Down
16 changes: 16 additions & 0 deletions gnovm/tests/files/math6.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package main

import (
"fmt"
)

func main() {
var a float64 = 0.0
var b float32 = 0.0
fmt.Println(a / a)
fmt.Println(b / b)
}

// Output:
// NaN
// NaN
24 changes: 24 additions & 0 deletions gnovm/tests/files/math7.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package main

import (
"fmt"
)

func main() {
var a float64 = 0.0
var b float32 = 0.0
fmt.Println(1 / a)
fmt.Println(0 / a)
fmt.Println(-1 / a)
fmt.Println(1 / b)
fmt.Println(0 / b)
fmt.Println(-1 / b)
}

// Output:
// +Inf
// NaN
// -Inf
// +Inf
// NaN
// -Inf
Loading