-
Notifications
You must be signed in to change notification settings - Fork 443
fix(gnoweb): handle multiline value for gno-textarea in forms #4978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Changes related to gnoweb must be reviewed by its codeowners Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Davphla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work, but I recommend to also support other special characters (e.g.: \t, which is the only pertinent in our case).
Maybe there's a package that interpret them directly?
Otherwise LGTM
|
@moonia , can you add a test for the specific use case in the original issue? |
Closes #4968
Description
The
<gno-textarea>component was literally displaying the\nsequence. After fix, the parser now interprets the\nsequence as a real newline character.Example
Before fix:
After fix: