-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-home icon #17
go-home icon #17
Conversation
@siko1056, while closing this merge request, have you pushed the patch into the hg repository? |
@luisrguerra, thanks for the new icon. When looking at your screenshot, I get the impression that the zoom icons are a little bit too bold. What do you think? And, in order to avoid misunderstandings with adding and removing actions, what do you think of a small magnifying glass around the symbols (although the old icons hadn't this either)? |
I thought about doing it like magnifying glass, I just didn't do it to not change the meaning of the icon. I can do it in the future |
I think it became a little too bold because it was made aligned to the 8x8 pixel grid |
@ttlmax This report was not intentionally closed by me. This is a side effect of deleting the accidentally created branch in this git clone of the Octave hg repository. I did not push any changes, but cannot reopen this report either without creating the "new-icons4" branch again. @luisrguerra Thank you very much for your contributions. We really appreciate this 🙂 👍 When creating PRs, please make sure to use "default" or "stable" as target branch to make them easy to merge 😉 |
I accidentally opened a branch in the official repository but I wasn't having permission to delete the branch I created myself. What doesn't make sense, seems to be some bug or conflict. I will redo the pull request in the future with the new changes with magnifying glass icons. |
Need to implement in the code

Tango icon:

Preview:
