Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-home icon #17

Closed
wants to merge 2 commits into from
Closed

Conversation

luisrguerra
Copy link
Member

@luisrguerra luisrguerra commented Mar 17, 2022

Need to implement in the code
go-home

Tango icon:
go-home

Preview:
preview

@siko1056 siko1056 deleted the branch gnu-octave:new-icons4 March 17, 2022 16:13
@siko1056 siko1056 closed this Mar 17, 2022
@ttlmax
Copy link
Contributor

ttlmax commented Mar 17, 2022

@siko1056, while closing this merge request, have you pushed the patch into the hg repository?

@ttlmax
Copy link
Contributor

ttlmax commented Mar 17, 2022

@luisrguerra, thanks for the new icon. When looking at your screenshot, I get the impression that the zoom icons are a little bit too bold. What do you think?

And, in order to avoid misunderstandings with adding and removing actions, what do you think of a small magnifying glass around the symbols (although the old icons hadn't this either)?

@luisrguerra
Copy link
Member Author

And, in order to avoid misunderstandings with adding and removing actions, what do you think of a small magnifying glass around the symbols (although the old icons hadn't this either)?

I thought about doing it like magnifying glass, I just didn't do it to not change the meaning of the icon. I can do it in the future

@luisrguerra
Copy link
Member Author

@luisrguerra, thanks for the new icon. When looking at your screenshot, I get the impression that the zoom icons are a little bit too bold. What do you think?

I think it became a little too bold because it was made aligned to the 8x8 pixel grid

@luisrguerra luisrguerra changed the title go-gome icon go-home icon Mar 17, 2022
@siko1056
Copy link
Member

@ttlmax This report was not intentionally closed by me. This is a side effect of deleting the accidentally created branch in this git clone of the Octave hg repository.

I did not push any changes, but cannot reopen this report either without creating the "new-icons4" branch again.

@luisrguerra Thank you very much for your contributions. We really appreciate this 🙂 👍 When creating PRs, please make sure to use "default" or "stable" as target branch to make them easy to merge 😉

@siko1056 siko1056 added the enhancement New feature or request label Mar 18, 2022
@luisrguerra
Copy link
Member Author

@ttlmax This report was not intentionally closed by me. This is a side effect of deleting the accidentally created branch in this git clone of the Octave hg repository.

I did not push any changes, but cannot reopen this report either without creating the "new-icons4" branch again.

@luisrguerra Thank you very much for your contributions. We really appreciate this 🙂 👍 When creating PRs, please make sure to use "default" or "stable" as target branch to make them easy to merge 😉

I accidentally opened a branch in the official repository but I wasn't having permission to delete the branch I created myself. What doesn't make sense, seems to be some bug or conflict. I will redo the pull request in the future with the new changes with magnifying glass icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants