Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename README to README.md #23

Closed
wants to merge 1 commit into from

Conversation

nsesodia
Copy link

Formatted README for better readability and scanability using markup. Added section about using octave software for users (not developers).

Formatted README for better readability and scanability. Added section about using octave software for users (not developers).
@siko1056
Copy link
Member

Thank for the pull-request (PR) @nsesodia .

This GitHub repository is just a mirror of the mercurial repository, thus there is no guarantee that Octave developers will review this PR. Maybe @mmuetzel can comment how to go forward with changes here.

octave_github

About the changes themselves. The GNU Standards of autotool (that Octave is using) demand a file to be called README without extension. https://www.gnu.org/software/automake/manual/html_node/Strictness.html

The Markdown changes look good, but it depends what the Octave developers prefer, as only pages like GitLab/GitHub display the README file nicely and so far the Octave project decided not to fully embrace GitLab/GitHub.

@siko1056 siko1056 added the enhancement New feature or request label Feb 18, 2024
@cbm755
Copy link
Contributor

cbm755 commented Feb 27, 2024

Perhaps we can make the formatting changes but leave the file as README (not README.md?)

along with Octave; see the file COPYING. If not, see
<https://www.gnu.org/licenses/>.
You should have received a copy of the
[`GNU General Public License`](https://github.com/gnu-octave/octave/blob/default/COPYING)
Copy link
Member

@mmuetzel mmuetzel Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub mirror is just that (a mirror of the main repository).
We shouldn't hard-code paths to the mirror repository here.


Bugs and Patches
----------------
See [Octave installation guide](https://github.com/gnu-octave/octave/blob/default/doc/interpreter/install.txi)
Copy link
Member

@mmuetzel mmuetzel Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.txi files are sources from which documentation is generated. Users shouldn't need to read those sources.

Maybe, use a link to the generated HTML documentation?
https://docs.octave.org/latest/Installation.html

Copyright (C) 1996-2024 The Octave Project Developers

See the file
[`COPYRIGHT.md`](https://github.com/gnu-octave/octave/blob/default/COPYRIGHT.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above:

The GitHub mirror is just that (a mirror of the main repository).
We shouldn't hard-code paths to the mirror repository here.

@mmuetzel
Copy link
Member

Some of the rewording of the file is probably ok.
I'm uncertain if changing to markdown is compliant to the autotools standard though.

Comment on lines +46 to +49
[here](https://ftp.gnu.org/gnu/octave)
and many mirror sites around the world. You may also find links to binary distributions
[here](https://www.octave.org/download.html).
The current development sources may be found under the Source Code tab on [Savannah](https://savannah.gnu.org/projects/octave/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to limit line length to 80 characters.

@mmuetzel
Copy link
Member

No more reaction of the original author in more than 2 weeks. Closing PR.
It can be reopened when there is further activity.

@mmuetzel mmuetzel closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants