add official bzip2 and curl pc files names

[talregev]

add official bzip2 pc file name:
https://gitlab.com/federicomenaquintero/bzip2/-/blob/master/bzip2.pc.in?ref_type=heads

Add official curl pc file name
https://github.com/curl/curl/blob/master/libcurl.pc.in

[mmuetzel]

Thank you for your contribution.
I haven't tested so far. But these changes are looking good to me. 👍

I'd like to push the changes you are proposing to the (upstream) Mercurial repository. For that, I'd need your name and a valid email address. Could you please share that information?
If you prefer to stay anonymous, I could also push those changes with me in the author field. Please, let me know how you would like to proceed.

[talregev]

May I propose a different PR that everytime user will make a PR here, it will trigger the ci?
I can do these changes myself.

[mmuetzel]

I will delete these information after your commit to the upstream, because I don't want bots will finds my email.

I don't know yet when I'll be able to push your changes. I'll try to do it some time this week.
But I have your information locally now. So, feel free to delete it from here whenever you like.

[talregev]

I will delete these information after your commit to the upstream, because I don't want bots will finds my email.

I don't know yet when I'll be able to push your changes. I'll try to do it some time this week. But I have your information locally now. So, feel free to delete it from here whenever you like.

Thank you!

[mmuetzel]

I slightly adapted your changes to Octave's coding style, added GNU-style commit messages and pushed the patches with you as the author upstream. They should be appearing shortly in this repository.

Thanks again for your contribution.

[dasergatskov]

That appears broke readline on MacOS.
See
https://savannah.gnu.org/bugs/?66745
and
https://octave.discourse.group/t/bind-invalid-command-blink-matching-paren/6170

[talregev]

I don't have macos to test octave on it.
On the ci with my commit, the macos looks green:
https://github.com/gnu-octave/octave/actions/runs/13058330610/job/36436677481
https://github.com/gnu-octave/octave/actions/runs/13058330610/job/36436677875
https://github.com/gnu-octave/octave/actions/runs/13058330610/job/36436678178
Can you add on the ci a test that detect that break?

In the discussion you found working solution:

I installed curl from homebrew, specified PKG_CONFIG_PATH=/opt/homebrew/opt/curl/lib/pkgconfig
and now everything works again.

Dmitri.

https://savannah.gnu.org/bugs/?66745#comment5

I am not sure how to tell configure to detect correctly the path for pkg config path.
If not solution is found, you can revert the change for libcurl, until solution is found also for macos.

[talregev]

Taken from discussion.

<   CURL LDFLAGS:                  -L/usr/lib
---
>   CURL LDFLAGS:
66262c66266
< CURL_LDFLAGS='-L/usr/lib'
---
> CURL_LDFLAGS=''

This curl you compile from source code?

[talregev]

From the ci:

2025-01-30T18:55:01.5069870Z   CURL CPPFLAGS:                 
2025-01-30T18:55:01.5070040Z   CURL LDFLAGS:                  
2025-01-30T18:55:01.5070210Z   CURL libraries:                -lcurl

In the ci, is the curl detected from .pc file?

[mmuetzel]

In the ci, is the curl detected from .pc file?

If I understand correctly, it is:

2025-01-31T22:10:49.2059190Z configure:97714: $PKG_CONFIG --exists --print-errors "libcurl"
2025-01-31T22:10:49.2059230Z configure:97717: $? = 0

I don't know which curl is installed on that runner. There are apparently multiple options for macOS...

[talregev]

I will add prints

[dasergatskov]

I don't know which curl is installed on that runner. There are apparently multiple options for macOS...

It must be the system curl. The one from Homebre is installed "keg-only", i.e. one needs to explicitly specify bin, lib, includes, or PKG_CONFIG_PATH to use it. So all CI builds are probably have the same problem. But since we do not have a BIST to test readline we do not know that.

[mmuetzel]

So all CI builds are probably have the same problem.

I'm not sure they do. If I understood your analysis on Savannah correctly, the issue arises because pkg-config --libs-only-L libcurl returns -L/usr/lib for you (which it shouldn't).
That doesn't seem to be the case for the CI runners on macOS. According to the configure summary, $CURL_LDFLAGS is empty for them.

At the moment, I'm inclined to think that it is an issue with your pkg-config (or its configuration). If I understand correctly, it shouldn't return flags to system libraries unless they are explicitly requested (e.g., with pkg-config --libs-only-L --keep-system-libs libcurl).
If it returns system libraries (i.e., -L/usr/lib) for you without --keep-system-libs, pkg-config might not be configured correctly...

[mmuetzel]

@talrgev kindly confirmed that the libcurl.pc that is used in the CI on macOS is the same that is also used on @dasergatskov's system:

  configure:97741: $PKG_CONFIG --exists --print-errors "libcurl"
  configure:97744: $? = 0
  configure:97755: found libcurl pc file in location "/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/13" version: 7.87.0

Yet, $CURL_LDFLAGS is empty in CI:

    CURL CPPFLAGS:                 
    CURL LDFLAGS:                  
    CURL libraries:                -lcurl

So, the issue that @dasergatskov is seeing is likely something local to his system.